linux-kernel - Re: [PATCH] perf llvm-add2line: Remove unused include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z37iZZm3Ev2UnDA-@x1>
Date: Wed, 8 Jan 2025 17:39:01 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Dmitry Vyukov <dvyukov@...gle.com>
Cc: namhyung@...nel.org, irogers@...gle.com,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf llvm-add2line: Remove unused include

On Wed, Jan 08, 2025 at 08:02:28AM +0100, Dmitry Vyukov wrote:
> Remove unused symbol_conf.h include.
> First, it's just unused. Second, it's problematic since this is a C++ file,
> and most perf headers don't compile as C++. So if any other includes are
> added to symbol_conf.h, it may break the build.

Thanks, applied to perf-tools-next,

- Arnaldo
 
> Signed-off-by: Dmitry Vyukov <dvyukov@...gle.com>
> Cc: Namhyung Kim <namhyung@...nel.org>
> Cc: Ian Rogers <irogers@...gle.com>
> Cc: linux-perf-users@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> ---
>  tools/perf/util/llvm-c-helpers.cpp | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tools/perf/util/llvm-c-helpers.cpp b/tools/perf/util/llvm-c-helpers.cpp
> index 663bcaba2041f..004081bd12c9c 100644
> --- a/tools/perf/util/llvm-c-helpers.cpp
> +++ b/tools/perf/util/llvm-c-helpers.cpp
> @@ -18,7 +18,6 @@
>  extern "C" {
>  #include <linux/zalloc.h>
>  }
> -#include "symbol_conf.h"
>  #include "llvm-c-helpers.h"
>  
>  extern "C"
> 
> base-commit: 09a0fa92e5b45e99cf435b2fbf5ebcf889cf8780
> -- 
> 2.47.1.613.gc27f4b7a9f-goog
>