linux-kernel - Re: [PATCH 09/10] netfilter: Add message pragma for deprecated xt_*.h, ipt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2b9c44e0-4527-db29-4e5e-b7ddd41bda8d@netfilter.org>
Date: Wed, 8 Jan 2025 21:51:06 +0100 (CET)
From: Jozsef Kadlecsik <kadlec@...filter.org>
To: Szőke Benjamin <egyszeregy@...email.hu>
cc: fw@...len.de, pablo@...filter.org, lorenzo@...nel.org, 
    daniel@...earbox.net, leitao@...ian.org, amiculas@...co.com, 
    davem@...emloft.net, dsahern@...nel.org, edumazet@...gle.com, 
    kuba@...nel.org, pabeni@...hat.com, horms@...nel.org, 
    netfilter-devel@...r.kernel.org, coreteam@...filter.org, 
    linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 09/10] netfilter: Add message pragma for deprecated
 xt_*.h, ipt_*.h.

On Tue, 7 Jan 2025, Szőke Benjamin wrote:

> 2025. 01. 07. 20:39 keltezéssel, Jozsef Kadlecsik írta:
> > On Tue, 7 Jan 2025, egyszeregy@...email.hu wrote:
> > 
> > > From: Benjamin Szőke <egyszeregy@...email.hu>
> > > 
> > > Display information about deprecated xt_*.h, ipt_*.h files
> > > at compile time. Recommended to use header files with
> > > lowercase name format in the future.
> > 
> > I still don't know whether adding the pragmas to notify about header 
> > file deprecation is a good idea.
> 
> Do you have any other ideas how can you display this information to the 
> users/customers, that it is time to stop using the uppercase header 
> files then they shall to use its merged lowercase named files instead in 
> their userspace SW?

Honestly, I don't know. What about Jan's clever idea of having the 
clashing filenames with identical content, i.e.

ipt_ttl.h:
#ifndef _IPT_TTL_H
#define _IPT_TTL_H
#include <linux/netfilter_ipv4/ipt_ttl_common.h>
#endif _IPT_TTL_H

ipt_TTL.h:
#ifndef _IPT_TTL_H
#define _IPT_TTL_H
#include <linux/netfilter_ipv4/ipt_ttl_common.h>
#endif _IPT_TTL_H

Would cloning such a repo on a case-insensitive filesystem produce errors 
or would work just fine?

Best regards,
Jozsef
-- 
E-mail : kadlec@...filter.org, kadlec@...ckhole.kfki.hu, kadlecsik.jozsef@...ner.hu
Address: Wigner Research Centre for Physics
         H-1525 Budapest 114, POB. 49, Hungary