linux-kernel - Re: [PATCH] dt-bindings: mmc: move compatible property to its specific binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFBinCAO0bpd7PXaVJWMby4Mqj1On5DaqNZua4V3gPUDms8=LA@mail.gmail.com>
Date: Wed, 8 Jan 2025 21:56:37 +0100
From: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
To: Dharma.B@...rochip.com
Cc: conor@...nel.org, ulf.hansson@...aro.org, robh@...nel.org, 
	krzk+dt@...nel.org, conor+dt@...nel.org, neil.armstrong@...aro.org, 
	khilman@...libre.com, jbrunet@...libre.com, linux-mmc@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: mmc: move compatible property to its
 specific binding

Hi Dharma,

On Wed, Jan 8, 2025 at 4:11 AM <Dharma.B@...rochip.com> wrote:
[...]
> "One issue is 'compatible' is required. Either that would have to be
> dropped as required."
>
> Instead of just dropping it from "required:", I removed the property
> itself and moved it to another binding.
>
> I will send a v2 by removing it from the required, will it be fine?
For me this is fine.

My understanding is that if we drop the compatible property completely
then any compatible string will be allowed (for example: compatible =
"random,name"). This is because mmc-slot.yaml inherits the properties
from mmc-controller-common.yaml which itself has
"additionalProperties: true".
However, if we allow it but make it optional it means that there's
only two valid states:
- no compatible property (on the Atmel / Microchip SoCs)
- a compatible property with the value "mmc-slot" (as used on Amlogic
Meson and Cavium Thunder SoCs)
- (anything else is considered invalid)

Rob, Conor: can confirm this or correct me wherever I got something wrong.
I hope that your feedback will help Dharma write a good patch
description for v2.


Best regards,
Martin