linux-kernel - Re: [PATCH v5 3/5] hyperv: Enable the hypercall output page for the VTL mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <729f82d5-804c-417c-a050-29682fd5eed8@linux.microsoft.com>
Date: Wed, 8 Jan 2025 13:22:13 -0800
From: Roman Kisel <romank@...ux.microsoft.com>
To: Nuno Das Neves <nunodasneves@...ux.microsoft.com>, hpa@...or.com,
 kys@...rosoft.com, bp@...en8.de, dave.hansen@...ux.intel.com,
 decui@...rosoft.com, eahariha@...ux.microsoft.com, haiyangz@...rosoft.com,
 mingo@...hat.com, mhklinux@...look.com, tglx@...utronix.de,
 tiala@...rosoft.com, wei.liu@...nel.org, linux-hyperv@...r.kernel.org,
 linux-kernel@...r.kernel.org, x86@...nel.org
Cc: apais@...rosoft.com, benhill@...rosoft.com, ssengar@...rosoft.com,
 sunilmut@...rosoft.com, vdso@...bites.dev
Subject: Re: [PATCH v5 3/5] hyperv: Enable the hypercall output page for the
 VTL mode



On 1/8/2025 1:08 PM, Nuno Das Neves wrote:
> On 12/30/2024 10:09 AM, Roman Kisel wrote:

[...]

> Replying in a new thread since I don't have all the context about the different
> VTL code paths that may need to converge. To my perspective, the approach in this
> patch seems perfectly reasonable to fix the current issue.
> 
> One small improvement might be to put this check into a helper function. That would
> make it easier to amend later when/if a clearly better solution is proposed.
> 
> Something like:
> 
> static inline bool hv_output_page_exists()
> {
> 	return hv_root_partition || IS_ENABLED(CONFIG_HYPERV_VTL_MODE);
> }

Will apply, thank you for the suggestion, Nuno!

> 
> Thanks
> Nuno

-- 
Thank you,
Roman