[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20250108234411.882768-1-apokusinski01@gmail.com>
Date: Thu, 9 Jan 2025 00:44:09 +0100
From: Antoni Pokusinski <apokusinski01@...il.com>
To: jic23@...nel.org,
lars@...afoo.de,
robh@...nel.org,
krzk+dt@...nel.org,
conor+dt@...nel.org,
andrej.skvortzov@...il.com,
neil.armstrong@...aro.org,
icenowy@...c.io,
megi@....cz,
danila@...xyga.com,
javier.carrasco.cruz@...il.com,
and@...nel.org
Cc: apokusinski01@...il.com,
linux-kernel@...r.kernel.org,
linux-iio@...r.kernel.org,
devicetree@...r.kernel.org
Subject: [PATCH v2 0/2] iio: magnetometer: add support for Si7210
This patch series adds support for the Si7210 Hall effect I2C sensor.
The driver currently supports the basic functionalities (i.e. making
temperature and magnetic field measurements and changing the
measurements scale) but I plan to add support for some other features in
the future as well (e.g. the digital output interrupt).
---
Hello,
Thanks for the review. In the v2, I implemented all the necessary
improvements, the most important ones being the `vdd-supply` in DT-binding
together with a regulator, changing the temperature measurement scale to
milli-celsius and removal of the `otp_lock`. The lock removal could be
done since we read the OTP memory in probe only.
Best regards,
Antoni
Changes since v1:
* dt-binding: add `vdd-supply`
* si7210: reorder includes in alphabetic order
* si7210: add comment for `fetch_lock`
* si7210: remove `otp_lock`
* si7210: fetch_measurement: change result type to __be16
* si7210: use guard(mutex) instead of scoped_guard
* si7210: read_raw: use FIELD_GET to get raw temperature value
* si7210: read_raw: return temperature in milli-celsius
* si7210: use regulator for getting the voltage
* si7210: si7210_device_wake: remove unnecessary cast
* si7210: si7210_device_init: use fsleep instead of usleep_range
* si7210: si7210_probe: remove i2c_set_clientdata()
* si7210: minor alignment and formatting fixes
Antoni Pokusinski (2):
dt-bindings: iio: magnetometer: add binding for Si7210
iio: magnetometer: si7210: add driver for Si7210
.../iio/magnetometer/silabs,si7210.yaml | 48 ++
drivers/iio/magnetometer/Kconfig | 11 +
drivers/iio/magnetometer/Makefile | 2 +
drivers/iio/magnetometer/si7210.c | 428 ++++++++++++++++++
4 files changed, 489 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/magnetometer/silabs,si7210.yaml
create mode 100644 drivers/iio/magnetometer/si7210.c
--
2.25.1
Powered by blists - more mailing lists