linux-kernel - Re: [PATCH] ARM: dts: aspeed: catalina: update catalina dts file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <59b47269065db207c2f0f8268d958b3f647fe05b.camel@codeconstruct.com.au>
Date: Wed, 08 Jan 2025 11:17:36 +1030
From: Andrew Jeffery <andrew@...econstruct.com.au>
To: Potin Lai <potin.lai.pt@...il.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski
	 <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Joel Stanley
	 <joel@....id.au>, Patrick Williams <patrick@...cx.xyz>
Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org, Cosmo Chou
	 <cosmo.chou@...ntatw.com>, Potin Lai <potin.lai@...ntatw.com>
Subject: Re: [PATCH] ARM: dts: aspeed: catalina: update catalina dts file

Hi Potin,

On Fri, 2025-01-03 at 09:42 +0800, Potin Lai wrote:
> Update device nodes list below for driver binding.

The devicetree describes the hardware. I prefer we keep references to
drivers out of the commit message here.

> 
> - Add IOB NIC thermal nodes (TMP421)
>   - 24-001f, 26-001f, 36-001f, 38-001f
> - Add FIO Remote thermal node (TMP75)
>   - 23-001f
> - Add Power sensor node (MP5990)
>   - 16-0022
> - Add main source fan controllers (MAX31790)
>   - 18-0021, 18-0027
> - Add 2nd source fan controllers (NCT7363)
>   - 18-0001, 18-0002
> - Add 2nd source HSC nodes (XDP710)
>   - 20-0013, 20-001c
> - Remove all ina238 nodes, move to userspace
>   - 16-0041, 16-0042, 16-0044, 17-0041, 17-0043

This seems to reflect the patch itself, which isn't terribly helpful.
The commit message should explain _why_ you're making the changes.

Can you please rework it?

Andrew