linux-kernel - Re: [PATCH RFC v2 6/22] selinux: rename comparison functions for clarity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56fbfb30cc249b4bb98354ffb449dae3@paul-moore.com>
Date: Tue, 07 Jan 2025 22:00:00 -0500
From: Paul Moore <paul@...l-moore.com>
To: Christian Göttsche <cgoettsche@...tendoof.de>, selinux@...r.kernel.org
Cc: Christian Göttsche <cgzones@...glemail.com>, Stephen Smalley <stephen.smalley.work@...il.com>, Ondrej Mosnacek <omosnace@...hat.com>, Nathan Chancellor <nathan@...nel.org>, Nick Desaulniers <ndesaulniers@...gle.com>, Bill Wendling <morbo@...gle.com>, Justin Stitt <justinstitt@...gle.com>, Thiébaud Weksteen <tweek@...gle.com>, Bram Bonné <brambonne@...gle.com>, Masahiro Yamada <masahiroy@...nel.org>, linux-kernel@...r.kernel.org, llvm@...ts.linux.dev, Eric Suen <ericsu@...ux.microsoft.com>, Canfeng Guo <guocanfeng@...ontech.com>, Casey Schaufler <casey@...aufler-ca.com>, GUO Zihua <guozihua@...wei.com>
Subject: Re: [PATCH RFC v2 6/22] selinux: rename comparison functions for  clarity

On Dec 16, 2024 =?UTF-8?q?Christian=20G=C3=B6ttsche?= <cgoettsche@...tendoof.de> wrote:
> 
> The functions context_cmp(), mls_context_cmp() and ebitmap_cmp() are not
> traditional C style compare functions returning -1, 0, and 1 for less
> than, equal, and greater than; they only return whether their arguments
> are equal.
> 
> Signed-off-by: Christian Göttsche <cgzones@...glemail.com>
> ---
> v2: also convert ebitmap_cmp() as suggested by Daniel
> ---
>  security/selinux/ss/context.c   |  2 +-
>  security/selinux/ss/context.h   | 14 +++++++-------
>  security/selinux/ss/ebitmap.c   |  8 ++++----
>  security/selinux/ss/ebitmap.h   |  2 +-
>  security/selinux/ss/mls_types.h |  2 +-
>  security/selinux/ss/services.c  |  2 +-
>  security/selinux/ss/sidtab.c    |  2 +-
>  7 files changed, 16 insertions(+), 16 deletions(-)

Merged into selinux/dev, thanks.

--
paul-moore.com