linux-kernel - Re: [PATCH v9 1/4] clk: qcom: gdsc: Release pm subdomains in reverse add order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <oqfqgjsglgvg6iox3aiizxafqxrczijknhs5vbxkqrj3om3rec@aovx5ra4woie>
Date: Tue, 7 Jan 2025 22:28:18 -0600
From: Bjorn Andersson <andersson@...nel.org>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
Cc: Michael Turquette <mturquette@...libre.com>, 
	Stephen Boyd <sboyd@...nel.org>, Dmitry Baryshkov <dmitry.baryshkov@...aro.org>, 
	Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>, Rajendra Nayak <quic_rjendra@...cinc.com>, 
	linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org, 
	stable@...r.kernel.org
Subject: Re: [PATCH v9 1/4] clk: qcom: gdsc: Release pm subdomains in reverse
 add order

On Mon, Jan 06, 2025 at 04:55:18PM +0000, Bryan O'Donoghue wrote:
> On 06/01/2025 16:53, Bjorn Andersson wrote:
> > This sounds very reasonable to me, but what's the actual reason?
> > 
> > > Fixes: 1b771839de05 ("clk: qcom: gdsc: enable optional power domain support")
> > > Cc:stable@...r.kernel.org
> > Without a reason it's hard to see why this needs to be backported.
> > 
> > Regards,
> > Bjorn
> 
> The reason is it makes the next patch much cleaner and makes backporting the
> Fixes in the next patch cleaner too.
> 

That makes sense, but let's state that in the commit message then.

> I could squash the two patches together as another option..

That would work too. Although in the unexpected case that the order has
any impact on outcome it would still be nice to have a comment about why
it was done - and why it was flagged for stable backporting.

Regards,
Bjorn