linux-kernel - Re: [RFC PATCH 0/3] ACPI: platform_profile: Let drivers dynamically refresh choices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <sjno57hd66wvjlplnv42fgb7wt62y5xh2dpbsx2r22x6mlneth@ohnyf3za545l>
Date: Wed, 8 Jan 2025 01:39:33 -0500
From: Kurt Borja <kuurtb@...il.com>
To: "Limonciello, Mario" <mario.limonciello@....com>
Cc: Hridesh MG <hridesh699@...il.com>, 
	Mark Pearson <mpearson-lenovo@...ebb.ca>, 
	"platform-driver-x86@...r.kernel.org" <platform-driver-x86@...r.kernel.org>, josh@...huagrisham.com, 
	"Derek J . Clark" <derekjohn.clark@...il.com>, "Rafael J. Wysocki" <rafael@...nel.org>, 
	Len Brown <lenb@...nel.org>, Maximilian Luz <luzmaximilian@...il.com>, 
	Hans de Goede <hdegoede@...hat.com>, Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>, 
	Lee Chun-Yi <jlee@...e.com>, Shyam Sundar S K <Shyam-sundar.S-k@....com>, 
	Corentin Chary <corentin.chary@...il.com>, "Luke D . Jones" <luke@...nes.dev>, 
	Lyndon Sanche <lsanche@...deno.ca>, Ike Panhc <ike.pan@...onical.com>, 
	Henrique de Moraes Holschuh <hmh@....eng.br>, Armin Wolf <W_Armin@....de>, 
	Colin Ian King <colin.i.king@...il.com>, Alexis Belmonte <alexbelm48@...il.com>, 
	Uwe Kleine-König <u.kleine-koenig@...libre.com>, Ai Chao <aichao@...inos.cn>, Gergo Koteles <soyer@....hu>, 
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>, linux-kernel@...r.kernel.org, Dell.Client.Kernel@...l.com, 
	ibm-acpi-devel@...ts.sourceforge.net
Subject: Re: [RFC PATCH 0/3] ACPI: platform_profile: Let drivers dynamically
 refresh choices

On Tue, Jan 07, 2025 at 11:28:06AM -0600, Limonciello, Mario wrote:
> > 
> > After giving it some thought, I agree with you and Hridesh. Kernel
> > should not limit profile choices if they *are* selectable.
> > 
> > If a "proof of concept" patch is still interesting I'll be glad to send
> > it, otherwise I think my original idea has too many problems. User-space
> > should be able to handle these special cases.
> > 
> > I think an attribute allowing/disallowing power sensitive values is
> > interesting. Maybe allow users too attach/detach individual profiles
> > from being selected/cycled? On that note, it would also be interesting to
> > be able to detach invidivual "profile handlers" from the legacy
> > `acpi_kobj`. But I'm not sure if this added complexity would be worth it.
> > 
> > Anyway.. Mario, do you think hiding platform_profile_handler from
> > drivers is something worth pursuing? Similar to what the hwmon class
> > does. I feel having some struct members like `minor` and `choices`
> > exposed, or having the profile_get/profile_set callbacks not being
> > const, while it's not the end of the world, could be problematic.
> 
> Yeah, I think this is still an interesting idea that's still worth pursuing.
> 
> Making the API simpler for drivers is a net benefit and reduction in tech
> debt.

That's good to hear.

I'm working on it! Hopefully I'll be able to submit it in a couple of
days.

~ Kurt

>