[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e39ee309-a8cd-4e65-b37a-74afb215c3b6@kernel.org>
Date: Wed, 8 Jan 2025 08:21:38 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Varadarajan Narayanan <quic_varada@...cinc.com>, bhelgaas@...gle.com,
lpieralisi@...nel.org, kw@...ux.com, manivannan.sadhasivam@...aro.org,
robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, vkoul@...nel.org,
kishon@...nel.org, andersson@...nel.org, konradybcio@...nel.org,
p.zabel@...gutronix.de, dmitry.baryshkov@...aro.org,
quic_nsekar@...cinc.com, linux-arm-msm@...r.kernel.org,
linux-pci@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-phy@...ts.infradead.org
Subject: Re: [PATCH v6 3/5] dt-bindings: PCI: qcom: Document the IPQ5332 PCIe
controller
On 08/01/2025 06:58, Varadarajan Narayanan wrote:
> Document the PCIe controller on IPQ5332 platform. IPQ5332 will
> use IPQ9574 as the fall back compatible.
>
> All DT entries except "reg" is similar between ipq5332 and
> ipq9574. ipq9574 has 5 registers while ipq5332 has 6. MHI is the
> additional (i.e. sixth entry). Since this matches with the
> sdx55's "reg" definition which allows for 5 or 6 registers,
> combine ipq9574 and ipq5332 with sdx55. Without this
> dt_binding_check fails.
>
> Signed-off-by: Varadarajan Narayanan <quic_varada@...cinc.com>
> ---
> v6: Commit message update only. Add info regarding the moving of
> ipq9574 from 5 "reg" definition to 5 or 6 reg definition.
>
You gave yourself 4 days to respond to my comment.
To me, you gave around 18h, through most of the time I was offline or
sleeping, and then sent new version.
NAK, implement the feedback and keep discussing in the previous version.
Best regards,
Krzysztof
Powered by blists - more mailing lists