linux-kernel - [v10 1/2] misc: pci_endpoint_test: Remove the "remainder" code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20250108080951.1700230-2-18255117159@163.com>
Date: Wed,  8 Jan 2025 16:09:50 +0800
From: Hans Zhang <18255117159@....com>
To: manivannan.sadhasivam@...aro.org
Cc: kw@...ux.com,
	kishon@...nel.org,
	arnd@...db.de,
	gregkh@...uxfoundation.org,
	linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	rockswang7@...il.com,
	Hans Zhang <18255117159@....com>,
	Niklas Cassel <cassel@...nel.org>
Subject: [v10 1/2] misc: pci_endpoint_test: Remove the "remainder" code

A BAR size is always a power of two. buf_size = min(SZ_1M, bar_size);
If the BAR size is <= 1MB, there will be 1 iteration, no remainder. If
the BAR size is > 1MB, there will be more than one iteration, but the
size will always be evenly divisible by 1MB, so no remainder.

Signed-off-by: Hans Zhang <18255117159@....com>
Suggested-by: Niklas Cassel <cassel@...nel.org>
Reviewed-by: Niklas Cassel <cassel@...nel.org>
---
Changes since v9:
https://lore.kernel.org/linux-pci/20250108072504.1696532-2-18255117159@163.com

- Remove the remain variable declaration.
---
 drivers/misc/pci_endpoint_test.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c
index 3aaaf47fa4ee..f78c7540c52c 100644
--- a/drivers/misc/pci_endpoint_test.c
+++ b/drivers/misc/pci_endpoint_test.c
@@ -280,7 +280,7 @@ static int pci_endpoint_test_bar_memcmp(struct pci_endpoint_test *test,
 static bool pci_endpoint_test_bar(struct pci_endpoint_test *test,
 				  enum pci_barno barno)
 {
-	int j, bar_size, buf_size, iters, remain;
+	int j, bar_size, buf_size, iters;
 	void *write_buf __free(kfree) = NULL;
 	void *read_buf __free(kfree) = NULL;
 	struct pci_dev *pdev = test->pdev;
@@ -313,12 +313,6 @@ static bool pci_endpoint_test_bar(struct pci_endpoint_test *test,
 						 write_buf, read_buf, buf_size))
 			return false;
 
-	remain = bar_size % buf_size;
-	if (remain)
-		if (pci_endpoint_test_bar_memcmp(test, barno, buf_size * iters,
-						 write_buf, read_buf, remain))
-			return false;
-
 	return true;
 }
 
-- 
2.25.1