linux-kernel - Re: [PATCH] m68k/atari: Use str_on_off() helper in atari_nvram_proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdV4c+rDzyfu+XhNR8c6F+Z3CUJ6EJSY8ic2DQzLokSSjA@mail.gmail.com>
Date: Wed, 8 Jan 2025 09:42:24 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Thorsten Blum <thorsten.blum@...ux.dev>
Cc: linux-m68k@...ts.linux-m68k.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] m68k/atari: Use str_on_off() helper in atari_nvram_proc_read()

On Fri, Dec 6, 2024 at 12:57 PM Thorsten Blum <thorsten.blum@...ux.dev> wrote:
> Remove hard-coded strings by using the str_on_off() helper function.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>

Reviewed-by: Geert Uytterhoeven <geert@...ux-m68k.org>
i.e. will queue in the m68k tree for v6.14.

I am adding

    #include <linux/string_choices.h>

while applying, as currently this relies on lots of implicit includes:

    arch/m68k/atari/nvram.c:#include <linux/seq_file.h>
    include/linux/seq_file.h:#include <linux/string_helpers.h>
    include/linux/string_helpers.h:#include <linux/string_choices.h>
    include/linux/string_choices.h:static inline const char *str_on_off(bool v)

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds