linux-kernel - Re: [PATCH v2] sched_ext: Replace rq_lock() to raw_spin_rq_lock() in scx_ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <67a26bd1-e7de-40eb-9545-2d8f815c30aa@igalia.com>
Date: Wed, 8 Jan 2025 17:46:10 +0900
From: Changwoo Min <changwoo@...lia.com>
To: Andrea Righi <arighi@...dia.com>
Cc: tj@...nel.org, void@...ifault.com, kernel-dev@...lia.com,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] sched_ext: Replace rq_lock() to raw_spin_rq_lock() in
 scx_ops_bypass()

Hello again,

On 25. 1. 8. 17:42, Andrea Righi wrote:
>> This change fixes: 0e7ffff1b811 ("scx: Fix raciness in scx_ops_bypass()")
> 
> We should use the `Fixes:` tag, put this right before your SoB line:
> 
>   Fixes: 0e7ffff1b811 ("scx: Fix raciness in scx_ops_bypass()")
Ah! My bad!

>>
>> Without this change, we observe the following warnings:
> 
> Maybe report only the first warning, or even something small like this
> should be sufficient to identify the issue I think:
> 
>   [    6.615205] rq->balance_callback && rq->balance_callback != &balance_push_callback
>   [    6.615208] WARNING: CPU: 2 PID: 0 at kernel/sched/sched.h:1730 __schedule+0x1130/0x1c90
Sure. Will fix it.

Regards,
Changwoo Min