linux-kernel - Re: [PATCH v5 1/2] dt-bindings: input: Add Nuvoton MA35D1 keypad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <629b18d8-8a16-4ac4-b72b-857105ba5834@kernel.org>
Date: Wed, 8 Jan 2025 09:55:48 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Ming-Jen Chen <mjchen0829@...il.com>
Cc: linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 linux-input@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 peng.fan@....com, arnd@...db.de, sudeep.holla@....com, conor+dt@...nel.org,
 krzk+dt@...nel.org, robh@...nel.org, dmitry.torokhov@...il.com
Subject: Re: [PATCH v5 1/2] dt-bindings: input: Add Nuvoton MA35D1 keypad

On 08/01/2025 09:42, Ming-Jen Chen wrote:
> 
> Krzysztof Kozlowski 於 2025/1/8 16:13 寫道:
>> On Wed, Jan 08, 2025 at 01:18:11AM +0000, Ming-Jen wrote:
>>> From: Ming-jen Chen <mjchen0829@...il.com>
>>>
>>> Add YAML bindings for MA35D1 SoC keypad.
>>>
>>> Signed-off-by: Ming-jen Chen <mjchen0829@...il.com>
>>> ---
>>>   .../bindings/input/nuvoton,ma35d1-keypad.yaml | 82 +++++++++++++++++++
>>>   1 file changed, 82 insertions(+)
>>>   create mode 100644 Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml b/Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml
>>> new file mode 100644
>>> index 000000000000..889f253b3bc2
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/input/nuvoton,ma35d1-keypad.yaml
>> I don't see changes.
>>
>> I already raised concern that you sent new versions without implementing
>> or responding to comments. So the fourth (!!!) time: Filename matching
>> compatible.
>>
>> Best regards,
>> Krzysztof
> 
> Thank you for your feedback! I now understand the changes I need to make.
> 
> I will modify it as blow:
> 
>    compatible:
>      const: nuvoton,ma35d1-keypad

Or change the filename...

Best regards,
Krzysztof