linux-kernel - Re: [PATCH 2/3] dt-bindings: hwmon: adi,max31827: add MAX31875

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4a4f9773-186c-475c-bfac-72e696233501@kernel.org>
Date: Wed, 8 Jan 2025 10:42:51 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: John Erasmus Mari Geronimo <johnerasmusmari.geronimo@...log.com>,
 devicetree@...r.kernel.org, linux-hwmon@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org
Cc: Jean Delvare <jdelvare@...e.com>, Guenter Roeck <linux@...ck-us.net>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Jonathan Corbet <corbet@....net>
Subject: Re: [PATCH 2/3] dt-bindings: hwmon: adi,max31827: add MAX31875

On 08/01/2025 09:25, John Erasmus Mari Geronimo wrote:
> Add max31875 to dt-bindings of max31827
> MAX31875 is low-power I2C temperature sensor similar to MAX31827
> 
> Signed-off-by: John Erasmus Mari Geronimo <johnerasmusmari.geronimo@...log.com>
> ---
>  .../bindings/hwmon/adi,max31827.yaml           | 18 ++++++++++++++++--
>  1 file changed, 16 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/adi,max31827.yaml b/Documentation/devicetree/bindings/hwmon/adi,max31827.yaml
> index f60e06ab7..9363fa371 100644
> --- a/Documentation/devicetree/bindings/hwmon/adi,max31827.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/adi,max31827.yaml
> @@ -4,16 +4,19 @@
>  $id: http://devicetree.org/schemas/hwmon/adi,max31827.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
> -title: Analog Devices MAX31827, MAX31828, MAX31829 Low-Power Temperature Switch
> +title: Analog Devices MAX31827, MAX31828, MAX31829, MAX31875 Low-Power Temperature Switch
>  
>  maintainers:
> -  - Daniel Matyas <daniel.matyas@...log.com>
> +  - John Erasmus Mari Geronimo <johnerasmusmari.geronimo@...log.com>


This needs to be explained in commit msg.

>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: adi,max31875
> +
> +    then:
> +      properties:
> +        adi,fault-q:
> +          enum: [1, 2, 4, 6]

You need to update top-level property to allow 6. Then narrow the
choices for rest of the variants.

>  
>  required:
>    - compatible


Best regards,
Krzysztof