linux-kernel - Re: [PATCH v4 2/3] soc: samsung: usi: implement support for USIv1 and exynos8895

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d0271581-c250-465a-aa0f-2f10548cc89b@kernel.org>
Date: Wed, 8 Jan 2025 11:08:57 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Ivaylo Ivanov <ivo.ivanov.ivanov1@...il.com>
Cc: Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 Alim Akhtar <alim.akhtar@...sung.com>,
 Sam Protsenko <semen.protsenko@...aro.org>,
 Peter Griffin <peter.griffin@...aro.org>, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/3] soc: samsung: usi: implement support for USIv1 and
 exynos8895

On 08/01/2025 10:45, Ivaylo Ivanov wrote:
>>>>> +
>>>>> +	return ret;
>>>>> +}
>>>>> +
>>>>> +static void exynos_usi_remove(struct platform_device *pdev)
>>>>> +{
>>>>> +	struct exynos_usi *usi = platform_get_drvdata(pdev);
>>>>> +
>>>>> +	if (usi->data->ver == USI_VER2)
>>>>> +		exynos_usi_disable(usi);
>>>> This is not related to the patch and should be separate patch, if at
>>>> all.
>>> Well I though that since didn't have any removal routine before it'd be good
>>> to introduce that and not leave USIv2 with hwacg set.
>> Sure, but separate commit, please. Can be preceeding the USIv1 support.
> 
> What about right after the USIv1 support? It would be less messy in my
> opinion.
Fixes should be before new features and why messy? You add devm cleanup
handler for unconfigure and in next commit you grow it with clk disable
for USIv1?

Best regards,
Krzysztof