linux-kernel - [PATCH] KVM: arm64: vgic: Update some comments to improve the code readability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250108103919.66572-1-daizhiyuan@phytium.com.cn>
Date: Wed,  8 Jan 2025 18:39:19 +0800
From: Zhiyuan Dai <daizhiyuan@...tium.com.cn>
To: maz@...nel.org,
	oliver.upton@...ux.dev,
	catalin.marinas@....com
Cc: joey.gouly@....com,
	uzuki.poulose@....com,
	yuzenghui@...wei.com,
	kvmarm@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	Zhiyuan Dai <daizhiyuan@...tium.com.cn>
Subject: [PATCH] KVM: arm64: vgic: Update some comments to improve the code readability

This patch updates the comments in the vgic_v3_queue_sgi function
to improve the readability of the code.

Signed-off-by: Zhiyuan Dai <daizhiyuan@...tium.com.cn>
---
 arch/arm64/kvm/vgic/vgic-mmio-v3.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/kvm/vgic/vgic-mmio-v3.c b/arch/arm64/kvm/vgic/vgic-mmio-v3.c
index ae4c0593d114..f3b328373869 100644
--- a/arch/arm64/kvm/vgic/vgic-mmio-v3.c
+++ b/arch/arm64/kvm/vgic/vgic-mmio-v3.c
@@ -1040,8 +1040,13 @@ static void vgic_v3_queue_sgi(struct kvm_vcpu *vcpu, u32 sgi, bool allow_group1)
 			irq->pending_latch = true;
 			vgic_queue_irq_unlock(vcpu->kvm, irq, flags);
 		} else {
-			/* HW SGI? Ask the GIC to inject it */
 			int err;
+
+			/*
+                        * With GICv4.1, vSGI can be directly injected.
+                        * So let's pretend that they are HW interrupts,
+                        * tied to a host IRQ.
+                        */
 			err = irq_set_irqchip_state(irq->host_irq,
 						    IRQCHIP_STATE_PENDING,
 						    true);
-- 
2.25.1