linux-kernel - Re: [PATCH V3 2/8] dt-bindings: remoteproc: qcom: document hexagon based WCSS secure PIL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7beda1b3-2fb2-490c-80fe-71f320d70ded@kernel.org>
Date: Wed, 8 Jan 2025 12:51:41 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "Gokul Sriram P (QUIC)" <quic_gokulsri@...cinc.com>,
 "dmitry.baryshkov@...aro.org" <dmitry.baryshkov@...aro.org>
Cc: "jassisinghbrar@...il.com" <jassisinghbrar@...il.com>,
 "robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
 <krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
 "andersson@...nel.org" <andersson@...nel.org>,
 "mathieu.poirier@...aro.org" <mathieu.poirier@...aro.org>,
 "konradybcio@...nel.org" <konradybcio@...nel.org>,
 "Manikanta Mylavarapu (QUIC)" <quic_mmanikan@...cinc.com>,
 "linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-remoteproc@...r.kernel.org" <linux-remoteproc@...r.kernel.org>,
 "Vignesh Viswanathan (QUIC)" <quic_viswanat@...cinc.com>,
 "Sricharan Ramabadhran (QUIC)" <quic_srichara@...cinc.com>
Subject: Re: [PATCH V3 2/8] dt-bindings: remoteproc: qcom: document hexagon
 based WCSS secure PIL

On 08/01/2025 12:19, Gokul Sriram P (QUIC) wrote:
> On 07/01/2025 13:56, Gokul Sriram P wrote:
>>>>> +examples:
>>>>> +  - |
>>>>> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
>>>>> +    #include <dt-bindings/clock/qcom,ipq5332-gcc.h>
>>>>> +    remoteproc@...0000 {
>>>>> +      compatible = "qcom,ipq5332-wcss-sec-pil";
>>>>> +      reg = <0xd100000 0x4040>;
>>>>> +      firmware-name = "ath12k/IPQ5332/hw1.0/q6_fw0.mdt";
>>>> Nit: .mbn
>>>>
>>>
>>> Hi Dmitry,
>>>
>>> Its .mdt format only in our case.
>>>
>> Then probably you need to fix your format.
> 
> Hi Dmitry/ Krzysztof,
> We use split firmware image where  .mbn image is split into x  segments with .b00 to .bxx extension. The mbn header along with signing metadata will be part of the .mdt. The secure authenticatior (TrustZone) will expect metadata as part of .mdt and will authenticate the .bxx segments.

NAK, you got feedback which you refuse to implement.

> 
> Certain msm platforms already support .mdt format as in https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/remoteproc/qcom,sm6115-pas.yaml?h=v6.13-rc6.

That's an overlook, not support. Don't use arguments "someone sneaked
it, so I can as well".

Best regards,
Krzysztof