linux-kernel - Re: [PATCH V6 01/15] PM / OPP: Expose refcounting helpers for the Rust implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025010821-yam-distaste-130f@gregkh>
Date: Wed, 8 Jan 2025 12:53:35 +0100
From: Greg KH <greg@...ah.com>
To: Viresh Kumar <viresh.kumar@...aro.org>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>,
	Miguel Ojeda <miguel.ojeda.sandonis@...il.com>,
	Danilo Krummrich <dakr@...hat.com>,
	Viresh Kumar <vireshk@...nel.org>, Nishanth Menon <nm@...com>,
	Stephen Boyd <sboyd@...nel.org>, Miguel Ojeda <ojeda@...nel.org>,
	Alex Gaynor <alex.gaynor@...il.com>,
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>,
	Benno Lossin <benno.lossin@...ton.me>,
	Andreas Hindborg <a.hindborg@...nel.org>,
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
	linux-pm@...r.kernel.org,
	Vincent Guittot <vincent.guittot@...aro.org>,
	rust-for-linux@...r.kernel.org,
	Manos Pitsidianakis <manos.pitsidianakis@...aro.org>,
	Erik Schilling <erik.schilling@...aro.org>,
	Alex Bennée <alex.bennee@...aro.org>,
	Joakim Bech <joakim.bech@...aro.org>, Rob Herring <robh@...nel.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V6 01/15] PM / OPP: Expose refcounting helpers for the
 Rust implementation

On Wed, Jan 08, 2025 at 02:41:24PM +0530, Viresh Kumar wrote:
> On 07-01-25, 12:58, Greg KH wrote:
> > On Tue, Jan 07, 2025 at 04:51:34PM +0530, Viresh Kumar wrote:
> > > The Rust implementation needs these APIs for its working. Expose them.
> > 
> > Why is the rust code unique here?  Why does C code not need these
> > exported?
> > 
> > And that first sentance isn't really good grammer :)
> > 
> > Also, you created a new function here and didn't document it anywhere,
> > nor do you mention it here in the changelog text, making this a
> > non-starter right off :(
> 
> How about this ?
> 
>     PM / OPP: Add reference counting helpers for Rust implementation
> 
>     To ensure that resources such as OPP tables or OPP nodes are not freed
>     while in use by the Rust implementation, it is necessary to increment
>     their reference count from Rust code.
> 
>     This commit introduces a new helper function,
>     `dev_pm_opp_get_opp_table_ref()`, to increment the reference count of an
>     OPP table and declares the existing helper `dev_pm_opp_get()` in
>     `pm_opp.h`.

That works, if you drop the `` stuff, not needed :)

thanks,

greg k-h