linux-kernel - Re: [PATCH v4 4/5] i3c: mipi-i3c-hci: use parity8 helper instead of open coding it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3117d2d9-260a-4e02-8c22-4e078e01ddd5@linux.intel.com>
Date: Wed, 8 Jan 2025 14:09:34 +0200
From: Jarkko Nikula <jarkko.nikula@...ux.intel.com>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>,
 linux-i3c@...ts.infradead.org
Cc: linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
 Alexandre Belloni <alexandre.belloni@...tlin.com>
Subject: Re: [PATCH v4 4/5] i3c: mipi-i3c-hci: use parity8 helper instead of
 open coding it

On 1/7/25 11:02 AM, Wolfram Sang wrote:
> The kernel has now a generic helper for getting parity with easier to
> understand semantics. Make use of it. Here, it also fixes a bug because
> the correct algorithm is using XOR ('^=') instead of ADD ('+=').
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
> Tested-by: Jarkko Nikula <jarkko.nikula@...ux.intel.com>
> ---
> 
> Change since v3:
> 
> * updated commit message to mention the bugfix
> 
> I intentionally did not add a Fixes tag because this fix depends on
> patch 1. The proper fix for backporting would change this to XOR, I'd
> think.
> 
Stable rules allow also cherry picking additional patches. To me picking 
patch 1 and 4 sounds better than an intermediate fix since bug has been 
here from the beginning. IMHO not so urgent than a regression.

Looks like we have been lucky. First dynamic address is 0x9 and previous 
algorithm gets the same calculated dat_w0 value for at least for the 
addresses 0x9 and 0xa.