linux-kernel - Re: [PATCH] dt-bindings: display: Correct indentation and style in DTS example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdXq3pLB1K5N9gFmBF6B0ohpLdKf0aj0WSuK17U-Bs4oUw@mail.gmail.com>
Date: Wed, 8 Jan 2025 13:53:21 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Neil Armstrong <neil.armstrong@...aro.org>, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, 
	Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Kevin Hilman <khilman@...libre.com>, Jerome Brunet <jbrunet@...libre.com>, 
	Martin Blumenstingl <martin.blumenstingl@...glemail.com>, 
	Andrzej Hajda <andrzej.hajda@...el.com>, Robert Foss <rfoss@...nel.org>, 
	Laurent Pinchart <Laurent.pinchart@...asonboard.com>, Jonas Karlman <jonas@...boo.se>, 
	Jernej Skrabec <jernej.skrabec@...il.com>, Shawn Guo <shawnguo@...nel.org>, 
	Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>, 
	Fabio Estevam <festevam@...il.com>, Inki Dae <inki.dae@...sung.com>, 
	Jagan Teki <jagan@...rulasolutions.com>, Marek Szyprowski <m.szyprowski@...sung.com>, 
	Chun-Kuang Hu <chunkuang.hu@...nel.org>, Philipp Zabel <p.zabel@...gutronix.de>, 
	Rob Clark <robdclark@...il.com>, Abhinav Kumar <quic_abhinavk@...cinc.com>, 
	Dmitry Baryshkov <dmitry.baryshkov@...aro.org>, Sean Paul <sean@...rly.run>, 
	Marijn Suijten <marijn.suijten@...ainline.org>, Matthias Brugger <matthias.bgg@...il.com>, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, 
	Geert Uytterhoeven <geert+renesas@...der.be>, Magnus Damm <magnus.damm@...il.com>, 
	Lucas Stach <l.stach@...gutronix.de>, Krishna Manikandan <quic_mkrishn@...cinc.com>, 
	Jonathan Marek <jonathan@...ek.ca>, Mahadevan <quic_mahap@...cinc.com>, 
	Kieran Bingham <kieran.bingham+renesas@...asonboard.com>, 
	Jacopo Mondi <jacopo+renesas@...ndi.org>, dri-devel@...ts.freedesktop.org, 
	linux-amlogic@...ts.infradead.org, devicetree@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	imx@...ts.linux.dev, linux-mediatek@...ts.infradead.org, 
	linux-arm-msm@...r.kernel.org, freedreno@...ts.freedesktop.org, 
	linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: display: Correct indentation and style in
 DTS example

Hi Krzysztof,

On Tue, Jan 7, 2025 at 1:58 PM Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
> DTS example in the bindings should be indented with 2- or 4-spaces and
> aligned with opening '- |', so correct any differences like 3-spaces or
> mixtures 2- and 4-spaces in one binding.
>
> No functional changes here, but saves some comments during reviews of
> new patches built on existing code.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Thanks for your patch!

> --- a/Documentation/devicetree/bindings/display/renesas,cmm.yaml
> +++ b/Documentation/devicetree/bindings/display/renesas,cmm.yaml
> @@ -58,10 +58,10 @@ examples:
>      #include <dt-bindings/power/r8a7796-sysc.h>
>
>      cmm0: cmm@...40000 {
> -         compatible = "renesas,r8a7796-cmm",
> -                      "renesas,rcar-gen3-cmm";
> -         reg = <0xfea40000 0x1000>;
> -         power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
> -         clocks = <&cpg CPG_MOD 711>;
> -         resets = <&cpg 711>;
> +        compatible = "renesas,r8a7796-cmm",
> +                     "renesas,rcar-gen3-cmm";

Nit: the compatible values fit on a single line.

> +        reg = <0xfea40000 0x1000>;
> +        power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
> +        clocks = <&cpg CPG_MOD 711>;
> +        resets = <&cpg 711>;
>      };

Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be> # renesas

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds