linux-kernel - Re: [PATCH net-next v2 13/14] net: ethernet: qualcomm: Add PPE debugfs support for PPE counters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f7e3d749-76cb-4fd8-a966-20cc1d9003fd@quicinc.com>
Date: Thu, 9 Jan 2025 22:24:59 +0800
From: Jie Luo <quic_luoj@...cinc.com>
To: Andrew Lunn <andrew@...n.ch>
CC: Andrew Lunn <andrew+netdev@...n.ch>,
        "David S. Miller"
	<davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Rob Herring
	<robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
	<conor+dt@...nel.org>, Lei Wei <quic_leiwei@...cinc.com>,
        Suruchi Agarwal
	<quic_suruchia@...cinc.com>,
        Pavithra R <quic_pavir@...cinc.com>,
        "Simon
 Horman" <horms@...nel.org>, Jonathan Corbet <corbet@....net>,
        Kees Cook
	<kees@...nel.org>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        "Philipp
 Zabel" <p.zabel@...gutronix.de>,
        <linux-arm-msm@...r.kernel.org>, <netdev@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-doc@...r.kernel.org>, <linux-hardening@...r.kernel.org>,
        <quic_kkumarcs@...cinc.com>, <quic_linchen@...cinc.com>,
        <srinivas.kandagatla@...aro.org>, <bartosz.golaszewski@...aro.org>,
        <john@...ozen.org>
Subject: Re: [PATCH net-next v2 13/14] net: ethernet: qualcomm: Add PPE
 debugfs support for PPE counters



On 1/9/2025 12:43 AM, Andrew Lunn wrote:
> On Wed, Jan 08, 2025 at 09:47:20PM +0800, Luo Jie wrote:
>> The PPE hardware packet counters are made available through
>> the debugfs entry "/sys/kernel/debug/ppe/packet_counters".
> 
> Why?
> 
> Would it not be better to make them available via ethtool -S ?

Many of the counters displayed by this debugfs are PPE hardware
counters that are common for all Ethernet ports. For example,
counters such as drops in PPE due to lack of hardware buffers.
Since ethtool -S output is tied to a netdevice, we felt that a
separate debugfs file to display these common counters is better.
The port specific counters will be supported using 'ethtool -S'
along with the netdevice driver that will be posted sequentially
after the conclusion of the review for this series.

> 
> You should justify not using standard statistics APIs for what look
> like statistic counters. Maybe these don't fit the existing API, and
> if so, you should explain why.
> 
> 	Andrew

I will enhance the commit message to justify these debug counters
in the next update. Hope this is fine.