linux-kernel - Re: [PATCH v2 01/14] btrfs: don't try to delete RAID stripe-extents if we don't need to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ca324436-f214-468d-a769-fd4f236313c0@wdc.com>
Date: Thu, 9 Jan 2025 14:39:35 +0000
From: Johannes Thumshirn <Johannes.Thumshirn@....com>
To: Filipe Manana <fdmanana@...nel.org>, Johannes Thumshirn <jth@...nel.org>
CC: Chris Mason <clm@...com>, Josef Bacik <josef@...icpanda.com>, David Sterba
	<dsterba@...e.com>, "linux-btrfs@...r.kernel.org"
	<linux-btrfs@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, Filipe Manana <fdmanana@...e.com>
Subject: Re: [PATCH v2 01/14] btrfs: don't try to delete RAID stripe-extents
 if we don't need to

On 09.01.25 13:35, Filipe Manana wrote:
>> diff --git a/fs/btrfs/tests/raid-stripe-tree-tests.c b/fs/btrfs/tests/raid-stripe-tree-tests.c
>> index 30f17eb7b6a8a1dfa9f66ed5508da42a70db1fa3..f060c04c7f76357e6d2c6ba78a8ba981e35645bd 100644
>> --- a/fs/btrfs/tests/raid-stripe-tree-tests.c
>> +++ b/fs/btrfs/tests/raid-stripe-tree-tests.c
>> @@ -478,8 +478,9 @@ static int run_test(test_func_t test, u32 sectorsize, u32 nodesize)
>>                  ret = PTR_ERR(root);
>>                  goto out;
>>          }
>> -       btrfs_set_super_compat_ro_flags(root->fs_info->super_copy,
>> +       btrfs_set_super_incompat_flags(root->fs_info->super_copy,
>>                                          BTRFS_FEATURE_INCOMPAT_RAID_STRIPE_TREE);
> This hunk seems unrelated to the rest of the patch, could be fixed in
> a different patch in case it actually solves any problem (probably
> not, but it's an incompat feature so it should be changed anyway).

I'll make it a separate patch. RST is an incompat feature not a compat one.

With this patch btrfs_delete_raid_extent() starts checking the incompat 
bit so it is fixing a 'problem'.