linux-kernel - Re: [PATCH v3] cpuidle: riscv-sbi: fix device node release in early exit of for_each_possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <173643941299.1375203.12210975797046480950.git-patchwork-notify@kernel.org>
Date: Thu, 09 Jan 2025 16:16:52 +0000
From: patchwork-bot+linux-riscv@...nel.org
To: Javier Carrasco <javier.carrasco.cruz@...il.com>
Cc: linux-riscv@...ts.infradead.org, anup@...infault.org, rafael@...nel.org,
 daniel.lezcano@...aro.org, paul.walmsley@...ive.com, palmer@...belt.com,
 aou@...s.berkeley.edu, atishp@...osinc.com, palmer@...osinc.com,
 linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
 ajones@...tanamicro.com
Subject: Re: [PATCH v3] cpuidle: riscv-sbi: fix device node release in early
 exit of for_each_possible_cpu

Hello:

This patch was applied to riscv/linux.git (fixes)
by Palmer Dabbelt <palmer@...osinc.com>:

On Sat, 16 Nov 2024 00:32:39 +0100 you wrote:
> The 'np' device_node is initialized via of_cpu_device_node_get(), which
> requires explicit calls to of_node_put() when it is no longer required
> to avoid leaking the resource.
> 
> Instead of adding the missing calls to of_node_put() in all execution
> paths, use the cleanup attribute for 'np' by means of the __free()
> macro, which automatically calls of_node_put() when the variable goes
> out of scope. Given that 'np' is only used within the
> for_each_possible_cpu(), reduce its scope to release the nood after
> every iteration of the loop.
> 
> [...]

Here is the summary with links:
  - [v3] cpuidle: riscv-sbi: fix device node release in early exit of for_each_possible_cpu
    https://git.kernel.org/riscv/c/7e25044b8045

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html