linux-kernel - Re: [PATCH 09/18] platform/x86: dell-pc: Use devm_platform_profile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fe620a84-6e4c-45b8-a53a-4f176c666f9a@amd.com>
Date: Thu, 9 Jan 2025 10:36:14 -0600
From: Mario Limonciello <mario.limonciello@....com>
To: Kurt Borja <kuurtb@...il.com>, platform-driver-x86@...r.kernel.org
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>,
 linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
 Armin Wolf <W_Armin@....de>, Joshua Grisham <josh@...huagrisham.com>,
 "Derek J . Clark" <derekjohn.clark@...il.com>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 Hans de Goede <hdegoede@...hat.com>, Maximilian Luz
 <luzmaximilian@...il.com>, "Lee, Chun-Yi" <jlee@...e.com>,
 Shyam Sundar S K <Shyam-sundar.S-k@....com>,
 Corentin Chary <corentin.chary@...il.com>, "Luke D. Jones"
 <luke@...nes.dev>, Lyndon Sanche <lsanche@...deno.ca>,
 Ike Panhc <ike.pan@...onical.com>,
 Henrique de Moraes Holschuh <hmh@....eng.br>,
 Mark Pearson <mpearson-lenovo@...ebb.ca>,
 Colin Ian King <colin.i.king@...il.com>,
 Alexis Belmonte <alexbelm48@...il.com>,
 Uwe Kleine-König <u.kleine-koenig@...libre.com>,
 Ai Chao <aichao@...inos.cn>, Gergo Koteles <soyer@....hu>,
 Dell.Client.Kernel@...l.com, ibm-acpi-devel@...ts.sourceforge.net
Subject: Re: [PATCH 09/18] platform/x86: dell-pc: Use
 devm_platform_profile_register()

On 1/9/2025 09:06, Kurt Borja wrote:
> Replace platform_profile_register() with it's device managed version.
> 
> Signed-off-by: Kurt Borja <kuurtb@...il.com>
Reviewed-by: Mario Limonciello <mario.limonciello@....com>
> ---
>   drivers/platform/x86/dell/dell-pc.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/platform/x86/dell/dell-pc.c b/drivers/platform/x86/dell/dell-pc.c
> index 1b6e60a63491..dda6f13295e8 100644
> --- a/drivers/platform/x86/dell/dell-pc.c
> +++ b/drivers/platform/x86/dell/dell-pc.c
> @@ -281,7 +281,7 @@ static int thermal_init(void)
>   	thermal_handler->ops = &dell_pc_platform_profile_ops;
>   
>   	/* Clean up if failed */
> -	ret = platform_profile_register(thermal_handler, NULL);
> +	ret = devm_platform_profile_register(thermal_handler, NULL);
>   	if (ret)
>   		goto cleanup_thermal_handler;
>   
> @@ -298,8 +298,6 @@ static int thermal_init(void)
>   
>   static void thermal_cleanup(void)
>   {
> -	if (thermal_handler)
> -		platform_profile_remove(thermal_handler);
>   	platform_device_unregister(platform_device);
>   }
>