linux-kernel - Re: [PATCH 13/18] platform/x86: thinkpad_acpi: Use devm_platform_profile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ed79eae8-41a8-4728-b2ea-dcda59badd64@amd.com>
Date: Thu, 9 Jan 2025 10:45:57 -0600
From: Mario Limonciello <mario.limonciello@....com>
To: Kurt Borja <kuurtb@...il.com>, platform-driver-x86@...r.kernel.org
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>,
 linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
 Armin Wolf <W_Armin@....de>, Joshua Grisham <josh@...huagrisham.com>,
 "Derek J . Clark" <derekjohn.clark@...il.com>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 Hans de Goede <hdegoede@...hat.com>, Maximilian Luz
 <luzmaximilian@...il.com>, "Lee, Chun-Yi" <jlee@...e.com>,
 Shyam Sundar S K <Shyam-sundar.S-k@....com>,
 Corentin Chary <corentin.chary@...il.com>, "Luke D. Jones"
 <luke@...nes.dev>, Lyndon Sanche <lsanche@...deno.ca>,
 Ike Panhc <ike.pan@...onical.com>,
 Henrique de Moraes Holschuh <hmh@....eng.br>,
 Mark Pearson <mpearson-lenovo@...ebb.ca>,
 Colin Ian King <colin.i.king@...il.com>,
 Alexis Belmonte <alexbelm48@...il.com>,
 Uwe Kleine-König <u.kleine-koenig@...libre.com>,
 Ai Chao <aichao@...inos.cn>, Gergo Koteles <soyer@....hu>,
 Dell.Client.Kernel@...l.com, ibm-acpi-devel@...ts.sourceforge.net
Subject: Re: [PATCH 13/18] platform/x86: thinkpad_acpi: Use
 devm_platform_profile_register()

On 1/9/2025 09:06, Kurt Borja wrote:
> Replace platform_profile_register() with it's device managed version.
> 
> Signed-off-by: Kurt Borja <kuurtb@...il.com>
Reviewed-by: Mario Limonciello <mario.limonciello@....com>
> ---
>   drivers/platform/x86/thinkpad_acpi.c | 8 +-------
>   1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index a72790cc5e0e..a0b8987bc328 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -10649,7 +10649,7 @@ static int tpacpi_dytc_profile_init(struct ibm_init_struct *iibm)
>   
>   	dytc_profile.dev = &tpacpi_pdev->dev;
>   	/* Create platform_profile structure and register */
> -	err = platform_profile_register(&dytc_profile, NULL);
> +	err = devm_platform_profile_register(&dytc_profile, NULL);
>   	/*
>   	 * If for some reason platform_profiles aren't enabled
>   	 * don't quit terminally.
> @@ -10667,14 +10667,8 @@ static int tpacpi_dytc_profile_init(struct ibm_init_struct *iibm)
>   	return 0;
>   }
>   
> -static void dytc_profile_exit(void)
> -{
> -	platform_profile_remove(&dytc_profile);
> -}
> -
>   static struct ibm_struct  dytc_profile_driver_data = {
>   	.name = "dytc-profile",
> -	.exit = dytc_profile_exit,
>   };
>   
>   /*************************************************************************