linux-kernel - Re: [PATCH] ASoC: amd: Add ACPI dependency to fix build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d77b1111-b113-4e47-bcf5-5584ded1d28f@amd.com>
Date: Thu, 9 Jan 2025 12:15:02 -0600
From: Mario Limonciello <mario.limonciello@....com>
To: Yu-Chun Lin <eleanor15x@...il.com>, lgirdwood@...il.com,
 broonie@...nel.org, perex@...ex.cz, tiwai@...e.com
Cc: linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org,
 visitorckw@...il.com, jserv@...s.ncku.edu.tw,
 kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] ASoC: amd: Add ACPI dependency to fix build error

On 1/9/2025 11:15, Yu-Chun Lin wrote:
> As reported by the kernel test robot, the following error occurs:
> 
>     sound/soc/amd/yc/acp6x-mach.c: In function 'acp6x_probe':
>>> sound/soc/amd/yc/acp6x-mach.c:573:15: error: implicit declaration of function 'acpi_evaluate_integer'; did you mean 'acpi_evaluate_object'? [-Werror=implicit-function-declaration]
>       573 |         ret = acpi_evaluate_integer(handle, "_WOV", NULL, &dmic_status);
>           |               ^~~~~~~~~~~~~~~~~~~~~
>           |               acpi_evaluate_object
>     cc1: some warnings being treated as errors
> 
> The function 'acpi_evaluate_integer' and its prototype in 'acpi_bus.h'
> are only available when 'CONFIG_ACPI' is enabled. Add a 'depends on ACPI'
> directive in Kconfig to ensure proper compilation.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202501090345.pBIDRTym-lkp@intel.com/
> Signed-off-by: Yu-Chun Lin <eleanor15x@...il.com>
Thanks for the fix!

Fixes: 4095cf872084 (ASoC: amd: yc: Fix for enabling DMIC on acp6x via 
_DSD entry)
Reviewed-by: Mario Limonciello <mario.limonciello@....com>

I was also worried about commit 88438444fdddd ("ASoC: amd: ps: Fix for 
enabling DMIC on acp63 platform via _DSD entry"), but this was set 
correctly originally in commit 1e4366489e2c0 ("ASoC: amd: enable Pink 
Sardine acp6.2 drivers build").

> ---
>   sound/soc/amd/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
> index c7590d4989bb..803521178279 100644
> --- a/sound/soc/amd/Kconfig
> +++ b/sound/soc/amd/Kconfig
> @@ -105,7 +105,7 @@ config SND_SOC_AMD_ACP6x
>   config SND_SOC_AMD_YC_MACH
>   	tristate "AMD YC support for DMIC"
>   	select SND_SOC_DMIC
> -	depends on SND_SOC_AMD_ACP6x
> +	depends on SND_SOC_AMD_ACP6x && ACPI
>   	help
>   	  This option enables machine driver for Yellow Carp platform
>   	  using dmic. ACP IP has PDM Decoder block with DMA controller.