linux-kernel - Re: [PATCH 00/16] KVM: TDX: TDX interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <38116f37-c720-4285-8aaf-1bd64f86c62d@linux.intel.com>
Date: Thu, 9 Jan 2025 10:44:08 +0800
From: Binbin Wu <binbin.wu@...ux.intel.com>
To: Sean Christopherson <seanjc@...gle.com>, Xiaoyao Li <xiaoyao.li@...el.com>
Cc: pbonzini@...hat.com, kvm@...r.kernel.org, rick.p.edgecombe@...el.com,
 kai.huang@...el.com, adrian.hunter@...el.com, reinette.chatre@...el.com,
 tony.lindgren@...ux.intel.com, isaku.yamahata@...el.com,
 yan.y.zhao@...el.com, chao.gao@...el.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/16] KVM: TDX: TDX interrupts




On 1/7/2025 4:08 AM, Sean Christopherson wrote:
> On Mon, Jan 06, 2025, Xiaoyao Li wrote:
>> On 12/9/2024 9:07 AM, Binbin Wu wrote:
>>> Hi,
>>>
>>> This patch series introduces the support of interrupt handling for TDX
>>> guests, including virtual interrupt injection and VM-Exits caused by
>>> vectored events.
>>>
>> (I'm not sure if it is the correct place to raise the discussion on
>> KVM_SET_LAPIC and KVM_SET_LAPIC for TDX. But it seems the most related
>> series)
>>
>> Should KVM reject KVM_GET_LAPIC and KVM_SET_LAPIC for TDX?
> Yes, IIRC that was what Paolo suggested in one of the many PUCK calls.  Until
> KVM supports intra-host migration for TDX guests, getting and setting APIC state
> is nonsensical.
>
By rejecting KVM_GET_LAPIC/KVM_SET_LAPIC for TDX guests (i.e.,
guest_apic_protected), I think it should return an error code instead of
returning 0.
Then it requires modifications in QEMU TDX support code to avoid requesting
KVM_GET_LAPIC/KVM_SET_LAPIC.