linux-kernel - Re: [PATCH V1 1/2] bnxt_en: Add TPH support in BNXT driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f1f6af31-7667-4416-95d0-2f59c91a1b62@amd.com>
Date: Thu, 9 Jan 2025 13:09:52 -0600
From: Wei Huang <wei.huang2@....com>
To: Jiri Slaby <jirislaby@...nel.org>, Jakub Kicinski <kuba@...nel.org>,
 bhelgaas@...gle.com
Cc: linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org, helgaas@...nel.org, davem@...emloft.net,
 edumazet@...gle.com, pabeni@...hat.com, asml.silence@...il.com,
 almasrymina@...gle.com, gospo@...adcom.com, michael.chan@...adcom.com,
 ajit.khaparde@...adcom.com, somnath.kotur@...adcom.com,
 andrew.gospodarek@...adcom.com, manoj.panicker2@....com,
 Eric.VanTassell@....com
Subject: Re: [PATCH V1 1/2] bnxt_en: Add TPH support in BNXT driver



On 1/8/25 05:33, Jiri Slaby wrote:
> On 15. 11. 24, 23:04, Jakub Kicinski wrote:
>> On Fri, 15 Nov 2024 14:04:11 -0600 Wei Huang wrote:
>>> +static void bnxt_irq_affinity_release(struct kref __always_unused *ref)
>>
>> unused? you're using it now
>>
>>> +{
>>> +    struct irq_affinity_notify *notify =
>>> +        (struct irq_affinity_notify *)
>>> +        container_of(ref, struct irq_affinity_notify, kref);
>>
>> this is ugly, and cast is unnecessary.
>>
>>> +    struct bnxt_irq *irq;
>>> +
>>> +    irq = container_of(notify, struct bnxt_irq, affinity_notify);
>>
>> since you init irq out of line you can as well init notify here
>>
>>> +    if (pcie_tph_set_st_entry(irq->bp->pdev, irq->msix_nr, 0)) {
>>
>> You checked this function can sleep, right? Because rtnl_lock()
>> will sleep.
> 
> Based on the above, I assume a new version was expected, but I cannot
> find any. So, Wei Huang, what's the status of this?

Currently the Broadcom team is driving the changes for upstream bnxt. I
will leave this question to them (Andy, Somnath, Michael).

> 
> thanks,