linux-kernel - [PATCH 0/2] device property: Warn on (of|fwnode|device)_property_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250109-dt-type-warnings-v1-0-0150e32e716c@kernel.org>
Date: Thu, 09 Jan 2025 13:42:04 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: "Rafael J. Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>, 
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, 
 Daniel Scally <djrscally@...il.com>, 
 Heikki Krogerus <heikki.krogerus@...ux.intel.com>, 
 Sakari Ailus <sakari.ailus@...ux.intel.com>, 
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
 Danilo Krummrich <dakr@...nel.org>, Saravana Kannan <saravanak@...gle.com>
Cc: linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org, 
 devicetree@...r.kernel.org
Subject: [PATCH 0/2] device property: Warn on
 (of|fwnode|device)_property_read_bool() for non-boolean properties

This series makes using (of|fwnode|device)_property_read_bool() on 
non-boolean properties give a warning when used with DT. This has been 
deprecated behavior for a while now. Soon we will add yet another 
variant of this function with a Rust binding[1].

Why not put the warning in the fwnode code? The fwnode code doesn't know 
the property's type as that depends on the firmware. For DT, a boolean 
is a property with no value.

Perhaps the ACPI backend should have a warning too? I looked briefly at 
it, but I don't have a clue how or if that can be detected. Doesn't look 
like there's a specific type for booleans. In any case, that would be an 
additional change on top of this series.

[1] https://lore.kernel.org/all/20241025-rust-platform-dev-v1-2-0df8dcf7c20b@kernel.org/

Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
---
Rob Herring (Arm) (2):
      device property: Split property reading bool and presence test ops
      of: Warn when of_property_read_bool() is used on non-boolean properties

 drivers/acpi/property.c  |  1 +
 drivers/base/property.c  | 38 ++++++++++++++++++++++++++++++++++++++
 drivers/base/swnode.c    |  1 +
 drivers/of/property.c    | 33 +++++++++++++++++++++++++++++++++
 include/linux/fwnode.h   |  3 +++
 include/linux/of.h       | 29 ++++++++++-------------------
 include/linux/property.h | 15 +++------------
 7 files changed, 89 insertions(+), 31 deletions(-)
---
base-commit: 40384c840ea1944d7c5a392e8975ed088ecf0b37
change-id: 20250109-dt-type-warnings-efe52d977bb2

Best regards,
-- 
Rob Herring (Arm) <robh@...nel.org>