linux-kernel - Re: [PATCH] Documentation: Remove the outdated prompt under cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zfjzkc1c.fsf@trenco.lwn.net>
Date: Thu, 09 Jan 2025 12:44:15 -0700
From: Jonathan Corbet <corbet@....net>
To: Jianhui Zhou <jianhuizz@...com>, akpm@...ux-foundation.org,
 paulmck@...nel.org, jonaszhou@...oxin.com
Cc: thuth@...hat.com, rostedt@...dmis.org, david@...hat.com,
 victor@...atatu.com, andrii@...nel.org, xiongwei.song@...driver.com,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org, Jianhui Zhou
 <jianhuizz@...com>, Tejun Heo <tj@...nel.org>
Subject: Re: [PATCH] Documentation: Remove the outdated prompt under
 cgroup_disable option in kernel-parameters.txt

It would have been good to include the cgroup maintainer here; adding
Tejun.

Looking at the code, it's far from clear to me that the other cgroups
pay attention to this parameter.  Can somebody convince me that this
change is correct?

Thanks,

jon

Jianhui Zhou <jianhuizz@...com> writes:

> Disabling options other than memory is currently
> supported according to the cgroup_disable function.
> So it can be removed.
>
> Signed-off-by: Jianhui Zhou <jianhuizz@...com>
> ---
>  Documentation/admin-guide/kernel-parameters.txt | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 3872bc6ec49d..3c562653016f 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -609,9 +609,6 @@
>  			- if foo is an optional feature then the feature is
>  			  disabled and corresponding cgroup files are not
>  			  created
> -			{Currently only "memory" controller deal with this and
> -			cut the overhead, others just disable the usage. So
> -			only cgroup_disable=memory is actually worthy}
>  			Specifying "pressure" disables per-cgroup pressure
>  			stall information accounting feature
>  
> -- 
> 2.25.1