linux-kernel - Re: [PATCH 1/1] KVM: VMX: Fix comment of handle_vmx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <173645183550.889475.2249096799180200711.b4-ty@google.com>
Date: Thu,  9 Jan 2025 11:47:23 -0800
From: Sean Christopherson <seanjc@...gle.com>
To: Sean Christopherson <seanjc@...gle.com>, pbonzini@...hat.com, mingo@...hat.com, 
	dave.hansen@...ux.intel.com, Gao Shiyuan <gaoshiyuan@...du.com>
Cc: kvm@...r.kernel.org, linux-kernel@...r.kernel.org, x86@...nel.org
Subject: Re: [PATCH 1/1] KVM: VMX: Fix comment of handle_vmx_instruction

On Fri, 03 Jan 2025 23:38:14 +0800, Gao Shiyuan wrote:
> There is no nested_vmx_setup function.

When referencing function, add parantheses, e.g. nested_vmx_setup(), so that it's
super obvious that you're talking about a function.

> It should be nested_vmx_hardware_setup overwrite the VMX emulate handler
> when nested=1.

Embarassingly, the comment was always wrong.  I added a paragraph to the changelog
to explain as much, e.g. so that we aren't as tempted to try and reword the comment
to avoid explicitly referencing function names so that it can't become stale.

Applied to kvm-x86 vmx, thanks!

[1/1] KVM: VMX: Fix comment of handle_vmx_instruction
      https://github.com/kvm-x86/linux/commit/4d141e444e26

--
https://github.com/kvm-x86/linux/tree/next