linux-kernel - Re: [PATCH v6 0/5] hyperv: Fixes for get_vtl(), hv_vtl_apicid_to_vp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z4BGI-yoptUPbF3v@liuwe-devbox-debian-v2>
Date: Thu, 9 Jan 2025 21:56:51 +0000
From: Wei Liu <wei.liu@...nel.org>
To: Roman Kisel <romank@...ux.microsoft.com>
Cc: Wei Liu <wei.liu@...nel.org>, hpa@...or.com, kys@...rosoft.com,
	bp@...en8.de, dave.hansen@...ux.intel.com, decui@...rosoft.com,
	eahariha@...ux.microsoft.com, haiyangz@...rosoft.com,
	mingo@...hat.com, mhklinux@...look.com,
	nunodasneves@...ux.microsoft.com, tglx@...utronix.de,
	tiala@...rosoft.com, linux-hyperv@...r.kernel.org,
	linux-kernel@...r.kernel.org, x86@...nel.org, apais@...rosoft.com,
	benhill@...rosoft.com, ssengar@...rosoft.com,
	sunilmut@...rosoft.com, vdso@...bites.dev
Subject: Re: [PATCH v6 0/5] hyperv: Fixes for get_vtl(),
 hv_vtl_apicid_to_vp_id()

On Thu, Jan 09, 2025 at 01:40:34PM -0800, Roman Kisel wrote:
> 
> 
> On 1/9/2025 12:18 PM, Wei Liu wrote:
> > On Wed, Jan 08, 2025 at 02:21:33PM -0800, Roman Kisel wrote:
> > [...]
> > > Roman Kisel (5):
> > >    hyperv: Define struct hv_output_get_vp_registers
> > >    hyperv: Fix pointer type in get_vtl(void)
> > >    hyperv: Enable the hypercall output page for the VTL mode
> > >    hyperv: Do not overlap the hvcall IO areas in get_vtl()
> > >    hyperv: Do not overlap the hvcall IO areas in hv_vtl_apicid_to_vp_id()
> > 
> > The patches have been pushed to hyperv-next. Roman and Nuno, please
> > check the tree for correctness.
> 
> This
> 
> ```c
> union hv_arm64_pending_synthetic_exception_event {
> 	u64 as_uint64[2];
> 	struct {
> 		u8 event_pending : 1;
> 		u8 event_type : 3;
> 		u8 reserved : 4;
> 		u8 rsvd[3];
> 		u64 context;
> 	} __packed;
> };
> ```
> 
> needs to have the `u32 exception_type;` field:
> 
> ```c
> union hv_arm64_pending_synthetic_exception_event {
> 	u64 as_uint64[2];
> 	struct {
> 		u8 event_pending : 1;
> 		u8 event_type : 3;
> 		u8 reserved : 4;
> 		u8 rsvd[3];
> 		u32 exception_type;
> 		u64 context;
> 	} __packed;
> };
> ```
> as otherwise the struct won't cover the array.
> Testing the VMs currently with the latest hyperv-next.

Fixed. I c&p'ed the code then deleted the right version of the struct.
Thanks for checking.

Wei.