linux-kernel - Re: [PATCH v11 2/2] binder: report txn errors via generic netlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z4BZjHjfanPi5h9W@google.com>
Date: Thu, 9 Jan 2025 23:19:40 +0000
From: Carlos Llamas <cmllamas@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Li Li <dualli@...omium.org>, dualli@...gle.com, corbet@....net,
	davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
	donald.hunter@...il.com, gregkh@...uxfoundation.org,
	arve@...roid.com, tkjos@...roid.com, maco@...roid.com,
	joel@...lfernandes.org, brauner@...nel.org, surenb@...gle.com,
	arnd@...db.de, masahiroy@...nel.org, bagasdotme@...il.com,
	horms@...nel.org, linux-kernel@...r.kernel.org,
	linux-doc@...r.kernel.org, netdev@...r.kernel.org,
	hridya@...gle.com, smoreland@...gle.com, kernel-team@...roid.com
Subject: Re: [PATCH v11 2/2] binder: report txn errors via generic netlink

On Thu, Jan 09, 2025 at 12:13:00PM -0800, Jakub Kicinski wrote:
> On Thu, 9 Jan 2025 11:48:24 -0800 Li Li wrote:
> > Cleaning up in the NETLINK_URELEASE notifier is better since we
> > register the process with the netlink socket. I'll change the code
> > accordingly.
> 
> Hm. Thought I already told you this. Maybe I'm mixing up submissions.
> 
> Please the unbind callback or possibly the sock priv infra
> (genl_sk_priv_get, sock_priv_destroy etc).

Sorry, it was me that suggested NETLINK_URELEASE. BTW, I did try those
genl_family callbacks first but I couldn't get them to work right away
so I moved on. I'll have a closer look now to figure out what I did
wrong. Thanks for the suggestion Jakub!

--
Carlos Llamas