linux-kernel - Re: [PATCH] staging: gpib: Remove commented-out line entirely (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d17e78a2-ad49-42da-a0d4-56c2f28baee4@stanley.mountain>
Date: Thu, 9 Jan 2025 10:43:35 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Sandeep Salwan <salwansandeep5@...il.com>
Cc: gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: gpib: Remove commented-out line entirely (v2)

On Wed, Jan 08, 2025 at 04:11:27PM -0500, Sandeep Salwan wrote:
> Per Greg’s feedback, remove the line instead of leaving it as a comment.
> It's not needed for debugging, so let's delete it completely. Thanks.

This isn't how we typically write commit messages.  Instead say:
This code has some debug code which is commented out.  Delete it.

> 
> Signed-off-by: Sandeep Salwan <salwansandeep5@...il.com>

There is a specific formula for v2 patches:
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

> ---
>  drivers/staging/gpib/agilent_82350b/agilent_82350b.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c b/drivers/staging/gpib/agilent_82350b/agilent_82350b.c
> index 3cd01613d067..7ba968e24add 100644
> --- a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c
> +++ b/drivers/staging/gpib/agilent_82350b/agilent_82350b.c
> @@ -31,10 +31,6 @@ int agilent_82350b_accel_read(gpib_board_t *board, uint8_t *buffer, size_t lengt
>  	int i, num_fifo_bytes;
>  	//hardware doesn't support checking for end-of-string character when using fifo
>  	if (tms_priv->eos_flags & REOS) {
> -		/*
> -		 * pr_info("ag-rd: using tms9914 read for REOS %x EOS %x\n",tms_priv->eos_flags,
> -		 * tms_priv->eos);
> -		 */
>  		return tms9914_read(board, tms_priv, buffer, length, end, bytes_read);
>  	}

Now that you have deleted the commented out code, the curly braces need
to be deleted as well.  You don't need to mention this in the commit
message.  It is obvious and assumed.

Please send a v3 of this patch.

regards,
dan carpenter