linux-kernel - Re: [PATCH 3/3] dt-bindings:Add SQ52206 to ina2xx devicetree bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250109082812.136268-1-wenliang202407@163.com>
Date: Thu,  9 Jan 2025 16:28:12 +0800
From: Wenliang Yan <wenliang202407@....com>
To: linux@...ck-us.net,
	krzk@...nel.org
Cc: conor+dt@...nel.org,
	corbet@....net,
	devicetree@...r.kernel.org,
	jdelvare@...e.com,
	krzk+dt@...nel.org,
	linux-hwmon@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	robh@...nel.org,
	wenliang202407@....com
Subject: Re: [PATCH 3/3] dt-bindings:Add SQ52206 to ina2xx devicetree bindings



At 2025-01-08 22:18:38, "Guenter Roeck" <linux@...ck-us.net> wrote:
>On 1/7/25 23:06, Krzysztof Kozlowski wrote:
>> On 07/01/2025 14:01, Wenliang Yan wrote:
>>>>>   Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml | 1 +
>>>>>   1 file changed, 1 insertion(+)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
>>>>> index 05a9cb36cd82..f0b7758ab29f 100644
>>>>> --- a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
>>>>> +++ b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
>>>>> @@ -20,6 +20,7 @@ description: |
>>>>>   properties:
>>>>>     compatible:
>>>>>       enum:
>>>>> +      - silergy,sq52206
>>>>
>>>> So it is compatible or not? You said same bindings, but not compatible?
>>>>
>>>
>>> What I mean is that SQ52206 is compatible.the datasheet depends on
>> 
>> 
>> Then compatibility should be expressed in fallback, but OTOH, your
>> linked changes suggest these are not compatible. Confusing commit msg.
>> 
>
>It is 'backward compatible' with additional features. That means it is not
>'compatible' in devicetree terminology.
>

Thank you for your explanation.
Although SQ52206 has added some new features, it has not affected the
hardware properties.The properties described in the ina2xx.yaml are
applicable to the sq52206 hardware.
So I will just add the sq52206 compatible to the ina2xx.yaml.yaml
from that series. Would that be fine from your side?

Thanks,
Wenliang Yan