linux-kernel - Re: [PATCH] tools: fixed compile tools/virtio error "_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025010943-chess-affluent-1bb5@gregkh>
Date: Thu, 9 Jan 2025 10:14:00 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Yufeng Wang <wangyufeng@...inos.cn>
Cc: Kees Cook <kees@...nel.org>, Andrew Morton <akpm@...ux-foundation.org>,
	Nathan Chancellor <nathan@...nel.org>,
	Jakub Kicinski <kuba@...nel.org>, Petr Pavlu <petr.pavlu@...e.com>,
	Yafang Shao <laoar.shao@...il.com>,
	Jan Hendrik Farr <kernel@...rr.cc>,
	Tony Ambardar <tony.ambardar@...il.com>,
	Alexander Potapenko <glider@...gle.com>,
	Uros Bizjak <ubizjak@...il.com>, Shunsuke Mie <mie@...l.co.jp>,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] tools: fixed compile tools/virtio error "__user"
 redefined [-Werror]

On Thu, Jan 09, 2025 at 04:43:41PM +0800, Yufeng Wang wrote:
> we use -Werror now, and warnings break the build so let's fixed it.
> 
> from virtio_test.c:17:
> ./linux/../../../include/linux/compiler_types.h:48: error: "__user" redefined [-Werror]
> 48 | # define __user BTF_TYPE_TAG(user)
> |
> In file included from ../../usr/include/linux/stat.h:5,
> from /usr/include/x86_64-linux-gnu/bits/statx.h:31,
> from /usr/include/x86_64-linux-gnu/sys/stat.h:465,
> from virtio_test.c:12:
> ../include/linux/types.h:56: note: this is the location of the previous definition
> 56 | #define __user
> 
> Cc: stable@...r.kernel.org
> 
> Signed-off-by: Yufeng Wang <wangyufeng@...inos.cn>
> ---
>  include/linux/compiler_types.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/compiler_types.h b/include/linux/compiler_types.h
> index 5d6544545658..3316e56140d6 100644
> --- a/include/linux/compiler_types.h
> +++ b/include/linux/compiler_types.h
> @@ -54,6 +54,7 @@ static inline void __chk_io_ptr(const volatile void __iomem *ptr) { }
>  # ifdef STRUCTLEAK_PLUGIN
>  #  define __user	__attribute__((user))
>  # else
> +#  undef __user
>  #  define __user	BTF_TYPE_TAG(user)
>  # endif
>  # define __iomem
> -- 
> 2.34.1

What commit does this fix?  Why is this suddenly showing up now?

thanks,

greg k-h