linux-kernel - Re: [PATCH net-next v2 01/14] dt-bindings: net: Add PPE for Qualcomm IPQ9574 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s7z6d6mza3a6bzmokwnuszpgkjqh2gnnxowdqklewzswogaapn@rhb5uhes7gbw>
Date: Thu, 9 Jan 2025 10:15:26 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Luo Jie <quic_luoj@...cinc.com>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Lei Wei <quic_leiwei@...cinc.com>, Suruchi Agarwal <quic_suruchia@...cinc.com>, 
	Pavithra R <quic_pavir@...cinc.com>, Simon Horman <horms@...nel.org>, 
	Jonathan Corbet <corbet@....net>, Kees Cook <kees@...nel.org>, 
	"Gustavo A. R. Silva" <gustavoars@...nel.org>, Philipp Zabel <p.zabel@...gutronix.de>, 
	linux-arm-msm@...r.kernel.org, netdev@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org, linux-hardening@...r.kernel.org, 
	quic_kkumarcs@...cinc.com, quic_linchen@...cinc.com, srinivas.kandagatla@...aro.org, 
	bartosz.golaszewski@...aro.org, john@...ozen.org
Subject: Re: [PATCH net-next v2 01/14] dt-bindings: net: Add PPE for Qualcomm
 IPQ9574 SoC

On Wed, Jan 08, 2025 at 09:47:08PM +0800, Luo Jie wrote:
> +    required:
> +      - clocks
> +      - clock-names
> +      - resets
> +      - interrupts
> +      - interrupt-names
> +
> +  ethernet-ports:

This device really looks like DSA or other ethernet switch, so I would
really expect proper $ref in top-level.

> +    type: object
> +    additionalProperties: false
> +    properties:
> +      '#address-cells':
> +        const: 1
> +      '#size-cells':
> +        const: 0
> +
> +    patternProperties:
> +      "^port@[1-6]$":
> +        type: object
> +        $ref: ethernet-controller.yaml#

Everything here is duplicating DSA or ethernet-switch, so that's
surprising.

> +        unevaluatedProperties: false
> +        description:
> +          PPE port that includes the MAC used to connect the external
> +          switch or PHY via the PCS.

Best regards,
Krzysztof