linux-kernel - Re: [PATCH] xfs: use kmemdup() to replace kmalloc + memcpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7c3kfhrtjpxrw44u44pow2un3q463w3qkiend2j374ixjqtfvb@rl33jhp7cmmu>
Date: Thu, 9 Jan 2025 10:39:25 +0100
From: Carlos Maiolino <cem@...nel.org>
To: Pei Xiao <xiaopei01@...inos.cn>
Cc: djwong@...nel.org, linux-xfs@...r.kernel.org, 
	linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] xfs: use kmemdup() to replace kmalloc + memcpy

On Fri, Dec 27, 2024 at 11:11:13AM +0800, Pei Xiao wrote:
> cocci warnings:
>     fs/xfs/libxfs/xfs_dir2.c:336:15-22: WARNING opportunity for kmemdup

https://lore.kernel.org/all/20241217225811.2437150-4-mtodorovac69@gmail.com/

> 
> Fixes: 30f712c9dd69 ("libxfs: move source files")
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202412260425.O3CDUhIi-lkp@intel.com/
> Signed-off-by: Pei Xiao <xiaopei01@...inos.cn>
> ---
>  fs/xfs/libxfs/xfs_dir2.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/xfs/libxfs/xfs_dir2.c b/fs/xfs/libxfs/xfs_dir2.c
> index 202468223bf9..24251e42bdeb 100644
> --- a/fs/xfs/libxfs/xfs_dir2.c
> +++ b/fs/xfs/libxfs/xfs_dir2.c
> @@ -379,12 +379,11 @@ xfs_dir_cilookup_result(
>  					!(args->op_flags & XFS_DA_OP_CILOOKUP))
>  		return -EEXIST;
>  
> -	args->value = kmalloc(len,
> +	args->value = kmemdup(name, len,
>  			GFP_KERNEL | __GFP_NOLOCKDEP | __GFP_RETRY_MAYFAIL);
>  	if (!args->value)
>  		return -ENOMEM;
>  
> -	memcpy(args->value, name, len);
>  	args->valuelen = len;
>  	return -EEXIST;
>  }
> -- 
> 2.25.1
> 
>