linux-kernel - Re: linux-next: build failure after merge of the pinctrl tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <A4F63773-E0C7-408F-B6FA-0B448D934804@public-files.de>
Date: Thu, 09 Jan 2025 12:27:28 +0100
From: Frank Wunderlich <frank-w@...lic-files.de>
To: Linus Walleij <linus.walleij@...aro.org>,
 Stephen Rothwell <sfr@...b.auug.org.au>
CC: Daniel Golle <daniel@...rotopia.org>,
 Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
 Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: build failure after merge of the pinctrl tree

Am 8. Januar 2025 22:58:01 MEZ schrieb Linus Walleij <linus.walleij@...aro.org>:
>On Wed, Jan 8, 2025 at 10:47 PM Stephen Rothwell <sfr@...b.auug.org.au> wrote:
>> On Mon, 6 Jan 2025 16:46:30 +1100 Stephen Rothwell <sfr@...b.auug.org.au> wrote:
>> >
>> > After merging the pinctrl tree, today's linux-next build (x86_64
>> > allmodconfig) failed like this:
>> >
>> > drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c: In function 'mtk_pinconf_bias_set_pd':
>> > drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c:606:13: error: unused variable 'err' [-Werror=unused-variable]
>> >   606 |         int err, pd;
>> >       |             ^~~
>> > drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c: At top level:
>> > drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c:602:12: error: 'mtk_pinconf_bias_set_pd' defined but not used [-Werror=unused-function]
>> >   602 | static int mtk_pinconf_bias_set_pd(struct mtk_pinctrl *hw,
>> >       |            ^~~~~~~~~~~~~~~~~~~~~~~
>> > cc1: all warnings being treated as errors
>> >
>> > Caused by commit
>> >
>> >   1673d720b7e2 ("pinctrl: mediatek: add support for MTK_PULL_PD_TYPE")
>> >
>> > I have used the pinctrl tree from next-20241220 for today.
>>
>> I am still seeing these errors.
>
>Sorry for not attending to it earlier.
>
>I fixed this up by just adding a patch deleting the unused
>mtk_pinconf_bias_set_pd() function. That should do it.
>
>Thanks Stephen!
>
>Yours,
>Linus Walleij

Hi,

Sorry, that was my mistake while changing daniels code to use mtk_pinconf_bias_set_pu_pd instead of this function based on angelos review. I forgot to drop this unused function (and did not notice it before sending last version).

Thank you Linus for providing the fix.
regards Frank