linux-kernel - Re: [PATCH v3] drm/bridge: it6505: fix HDCP V match check is not performed correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <o5g7js2ysodvev2bcmeqndq656qhauu5tgdrkwrwv3go2wf7z4@y3ae3routohb>
Date: Fri, 10 Jan 2025 04:13:34 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Hermes.Wu@....com.tw
Cc: andrzej.hajda@...el.com, neil.armstrong@...aro.org, rfoss@...nel.org, 
	Laurent.pinchart@...asonboard.com, jonas@...boo.se, jernej.skrabec@...il.com, 
	maarten.lankhorst@...ux.intel.com, mripard@...nel.org, tzimmermann@...e.de, airlied@...il.com, 
	simona@...ll.ch, angelogioacchino.delregno@...labora.com, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, Pet.Weng@....com.tw, 
	Kenneth.Hung@....com.tw, treapking@...omium.org
Subject: Re: [PATCH v3] drm/bridge: it6505: fix HDCP V match check is not
 performed correctly

On Fri, Jan 10, 2025 at 02:00:35AM +0000, Hermes.Wu@....com.tw wrote:
> hi
> 
> 
> -----Original Message-----
> From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org> 
> Sent: Thursday, January 9, 2025 9:09 PM
> To: Hermes Wu (吳佳宏) <Hermes.Wu@....com.tw>
> Cc: Andrzej Hajda <andrzej.hajda@...el.com>; Neil Armstrong <neil.armstrong@...aro.org>; Robert Foss <rfoss@...nel.org>; Laurent Pinchart <Laurent.pinchart@...asonboard.com>; Jonas Karlman <jonas@...boo.se>; Jernej Skrabec <jernej.skrabec@...il.com>; Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>; Maxime Ripard <mripard@...nel.org>; Thomas Zimmermann <tzimmermann@...e.de>; David Airlie <airlied@...il.com>; Simona Vetter <simona@...ll.ch>; AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>; dri-devel@...ts.freedesktop.org; linux-kernel@...r.kernel.org; Pet Weng (翁玉芬) <Pet.Weng@....com.tw>; Kenneth Hung (洪家倫) <Kenneth.Hung@....com.tw>; treapking@...omium.org
> Subject: Re: [PATCH v3] drm/bridge: it6505: fix HDCP V match check is not performed correctly
> 
> On Thu, Jan 09, 2025 at 02:40:08PM +0800, Hermes Wu via B4 Relay wrote:
> > From: Hermes Wu <Hermes.wu@....com.tw>
> > 
> > The loop of V compare is expected to iterate for 5 times which compare 
> > V array form av[0][] to av[4][].
> > It should check loop counter reach the last statement "i == 5"
> > before return true
> > 
> > Fixes: 0989c02c7a5c ("drm/bridge: it6505: fix HDCP CTS compare V 
> > matching")
> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> >Excuse me, where did you get that from?? I didn't r-b it (yet).
> 
> Sorry,
> 
> I think I just missing understanding about this tag.
> I thought it should add if someone give advice to a path.
> 
> So I add it before you r-b it,

Okay. Please don't add extra tags in future.

The patch itself is:


Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>


> 
> > Signed-off-by: Hermes Wu <Hermes.wu@....com.tw>
> > ---
> > Changes in v3:
> > - The V value compare loop from i = 0 to i = 4 and shall exit with i == 5 
> >   if all V element matches
> > - Link to v2: 
> > https://lore.kernel.org/r/20250109-fix-hdcp-v-comp-v2-1-7dce0a59523f@i
> > te.com.tw
> > 
> > Changes in v2:
> > - pull the check of statment "i" out of V value check loop
> > - Link to v1: 
> > https://lore.kernel.org/r/20250108-fix-hdcp-v-comp-v1-1-9404811825cd@i
> > te.com.tw
> > ---
> >  drivers/gpu/drm/bridge/ite-it6505.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> >--
> >With best wishes
> >Dmitry
> 
> Br.
> Hermes

-- 
With best wishes
Dmitry