linux-kernel - Re: [PATCH v2] iio: gts: Simplify available scale table build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a49a57c0-e3fa-4d4a-aec7-be8f7a681f3b@gmail.com>
Date: Fri, 10 Jan 2025 16:26:19 +0200
From: Matti Vaittinen <mazziesaccount@...il.com>
To: Jonathan Cameron <jic23@...nel.org>
Cc: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
 Lars-Peter Clausen <lars@...afoo.de>,
 Subhajit Ghosh <subhajit.ghosh@...aklogic.com>,
 Mudit Sharma <muditsharma.info@...il.com>, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] iio: gts: Simplify available scale table build

On 22/12/2024 11:24, Matti Vaittinen wrote:
> On 20/12/2024 21:21, Jonathan Cameron wrote:
>> On Mon, 16 Dec 2024 10:56:37 +0200
>> Matti Vaittinen <mazziesaccount@...il.com> wrote:
>>
>>> Make available scale building more clear. This hurts the performance
>>> quite a bit by looping throgh the scales many times instead of doing
>>> everything in one loop. It however simplifies logic by:
>>>   - decoupling the gain and scale allocations & computations
>>>   - keeping the temporary 'per_time_gains' table inside the
>>>     per_time_scales computation function.
>>>   - separating building the 'all scales' table in own function and doing
>>>     it based on the already computed per-time scales.
>>>
>>> Signed-off-by: Matti Vaittinen <mazziesaccount@...il.com>
>> Looks good to me, but I want to leave it on list a while before applying.
>> Ideal if it gets some tested-by or other tags before I pick it up.
>> As always, this is fiddly code, so the more eyes the better!
> 
> Please, let it wait until the Christmas has passed. I got information we 
> might be getting some testing before the year changes :)

Well, the year changed and no tested-by tags emerged. I suppose my 
sources weren't right at this time.

Yours,
	-- Matti