linux-kernel - Re: [PATCH v2 20/27] spi: spi-mem: Estimate the time taken by operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87tta6ag5b.fsf@bootlin.com>
Date: Fri, 10 Jan 2025 15:37:52 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Mark Brown <broonie@...nel.org>
Cc: Sanjay R Mehta <sanju.mehta@....com>,  Serge Semin
 <fancer.lancer@...il.com>,  Han Xu <han.xu@....com>,  Conor Dooley
 <conor.dooley@...rochip.com>,  Daire McNamara
 <daire.mcnamara@...rochip.com>,  Matthias Brugger
 <matthias.bgg@...il.com>,  AngeloGioacchino Del Regno
 <angelogioacchino.delregno@...labora.com>,  Haibo Chen
 <haibo.chen@....com>,  Yogesh Gaur <yogeshgaur.83@...il.com>,  Heiko
 Stuebner <heiko@...ech.de>,  Michal Simek <michal.simek@....com>,  Richard
 Weinberger <richard@....at>,  Vignesh Raghavendra <vigneshr@...com>,
  Jacky Huang <ychuang3@...oton.com>,  Shan-Chun Hung <schung@...oton.com>,
  Chin-Ting Kuo <chin-ting_kuo@...eedtech.com>,  Cédric Le
 Goater
 <clg@...d.org>,  Joel Stanley <joel@....id.au>,  Andrew Jeffery
 <andrew@...econstruct.com.au>,  Avi Fishman <avifishman70@...il.com>,
  Tomer Maimon <tmaimon77@...il.com>,  Tali Perry <tali.perry1@...il.com>,
  Patrick Venture <venture@...gle.com>,  Nancy Yuen <yuenn@...gle.com>,
  Benjamin Fair <benjaminfair@...gle.com>,  Maxime Coquelin
 <mcoquelin.stm32@...il.com>,  Alexandre Torgue
 <alexandre.torgue@...s.st.com>,  Raju Rangoju <Raju.Rangoju@....com>,
  Thomas Petazzoni <thomas.petazzoni@...tlin.com>,  Steam Lin
 <stlin2@...bond.com>,  linux-spi@...r.kernel.org,
  linux-kernel@...r.kernel.org,  imx@...ts.linux.dev,
  linux-riscv@...ts.infradead.org,  linux-arm-kernel@...ts.infradead.org,
  linux-mediatek@...ts.infradead.org,  linux-rockchip@...ts.infradead.org,
  linux-mtd@...ts.infradead.org,  linux-aspeed@...ts.ozlabs.org,
  openbmc@...ts.ozlabs.org,  linux-stm32@...md-mailman.stormreply.com
Subject: Re: [PATCH v2 20/27] spi: spi-mem: Estimate the time taken by
 operations

Hi Mark,

On 10/01/2025 at 12:42:47 GMT, Mark Brown <broonie@...nel.org> wrote:

> On Tue, Dec 24, 2024 at 06:06:05PM +0100, Miquel Raynal wrote:
>> In the SPI-NAND layer, we currently make list of operation variants from
>> the fastest one to the slowest and there is a bit of logic in the core
>> to go over them and pick the first one that is supported by the
>> controller, ie. the fastest one among the supported ops.
>
> This breaks the build:
>
> /build/stage/linux/drivers/spi/spi-mem.c:580:5: error: conflicting types for ‘spi_mem_calc_op_duration’; have ‘u64(struct spi_mem_op *)’ {aka ‘long long unsigned int(struct spi_mem_op *)’}
>   580 | u64 spi_mem_calc_op_duration(struct spi_mem_op *op)

Crap, that's a fixup that landed in the wrong commit (mtd: spinand:
Enhance the logic when picking a variant). I'll fix it.

Thanks,
Miquèl