linux-kernel - Re: [PATCH] cpufreq: Move endif to the end of Kconfig file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z4EyAQuuBSOV5Xwd@bogus>
Date: Fri, 10 Jan 2025 14:43:13 +0000
From: Sudeep Holla <sudeep.holla@....com>
To: Viresh Kumar <viresh.kumar@...aro.org>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>,
	Sunil V L <sunilvl@...tanamicro.com>,
	Palmer Dabbelt <palmer@...osinc.com>,
	Pierre Gondois <pierre.gondois@....com>, linux-pm@...r.kernel.org,
	Sudeep Holla <sudeep.holla@....com>,
	Vincent Guittot <vincent.guittot@...aro.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpufreq: Move endif to the end of Kconfig file

On Fri, Jan 10, 2025 at 11:23:10AM +0530, Viresh Kumar wrote:
> It is possible to enable few cpufreq drivers, without the framework
> being enabled. This happened due to a bug while moving the entries
> earlier. Fix it.
>

Surprising to see how randconfigs has not managed to catch this so far.

Anyways,

Reviewed-by: Sudeep Holla <sudeep.holla@....com>

> Fixes: 7ee1378736f0 ("cpufreq: Move CPPC configs to common Kconfig and add RISC-V")
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
> ---
>  drivers/cpufreq/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
> index ea9afdc119fb..d64b07ec48e5 100644
> --- a/drivers/cpufreq/Kconfig
> +++ b/drivers/cpufreq/Kconfig
> @@ -325,8 +325,6 @@ config QORIQ_CPUFREQ
>  	  This adds the CPUFreq driver support for Freescale QorIQ SoCs
>  	  which are capable of changing the CPU's frequency dynamically.
>  
> -endif
> -
>  config ACPI_CPPC_CPUFREQ
>  	tristate "CPUFreq driver based on the ACPI CPPC spec"
>  	depends on ACPI_PROCESSOR
> @@ -355,4 +353,6 @@ config ACPI_CPPC_CPUFREQ_FIE
>  
>  	  If in doubt, say N.
>  
> +endif
> +
>  endmenu
> -- 
> 2.31.1.272.g89b43f80a514
> 

-- 
Regards,
Sudeep