linux-kernel - Re: [PATCH 10/19] powerpc: dts: Add MPC8314E devicetree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e1c8ebd5-b01d-4338-a465-889853d1ef9f@kernel.org>
Date: Fri, 10 Jan 2025 16:21:58 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: j.ne@...teo.net, Michael Ellerman <mpe@...erman.id.au>,
 Nicholas Piggin <npiggin@...il.com>,
 Christophe Leroy <christophe.leroy@...roup.eu>,
 Naveen N Rao <naveen@...nel.org>, Madhavan Srinivasan <maddy@...ux.ibm.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Linus Walleij
 <linus.walleij@...aro.org>, Bartosz Golaszewski <brgl@...ev.pl>,
 Frank Li <Frank.Li@....com>
Cc: linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org, linux-gpio@...r.kernel.org
Subject: Re: [PATCH 10/19] powerpc: dts: Add MPC8314E devicetree

On 02/01/2025 19:31, J. Neuschäfer via B4 Relay wrote:
> From: "J. Neuschäfer" <j.ne@...teo.net>
> 
> The MPC8314E is a variant of the MPC8315E without SATA controllers.
> 
> Signed-off-by: J. Neuschäfer <j.ne@...teo.net>
> ---
>  arch/powerpc/boot/dts/mpc8314e.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/powerpc/boot/dts/mpc8314e.dtsi b/arch/powerpc/boot/dts/mpc8314e.dtsi
> new file mode 100644
> index 0000000000000000000000000000000000000000..65a96a485dded5d4918d96b38778399d2f348190
> --- /dev/null
> +++ b/arch/powerpc/boot/dts/mpc8314e.dtsi
> @@ -0,0 +1,7 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +// Copyright 2024 J. Neuschäfer
> +#include "mpc8315e.dtsi"
> +
> +/* MPC8314E does not support SATA */
> +/delete-node/ &sata0;
> +/delete-node/ &sata1;


You should not delete nodes. That's not really maintainable code. Either
this is in base DTSI or it does not. If it does exist, then this delete
is incorrect.

If it does not delete, you are not supposed to include other SoC/device
which is not the subset of this one, so your includes are not correct.

Best regards,
Krzysztof