linux-kernel - Re: [REGRESSION][BISECTED] BU40N Blu-Ray drive broken since 7627a0edef54

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <69589dad-c0c8-4a72-9f3d-c1b0c29c96c1@heusel.eu>
Date: Fri, 10 Jan 2025 17:21:32 +0100
From: Christian Heusel <christian@...sel.eu>
To: Niklas Cassel <cassel@...nel.org>
Cc: Mario Limonciello <mario.limonciello@....com>, 
	Damien Le Moal <dlemoal@...nel.org>, Mika Westerberg <mika.westerberg@...ux.intel.com>, 
	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org, regressions@...ts.linux.dev
Subject: Re: [REGRESSION][BISECTED] BU40N Blu-Ray drive broken since
 7627a0edef54

On 25/01/10 12:24PM, Niklas Cassel wrote:
> On Fri, Jan 10, 2025 at 10:04:46AM +0100, Christian Heusel wrote:
>
> > diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> > index c085dd8..ef01ccd 100644
> > --- a/drivers/ata/libata-core.c
> > +++ b/drivers/ata/libata-core.c
> > @@ -4118,6 +4118,9 @@ static const struct ata_dev_quirks_entry __ata_dev_quirks[] = {
> >  	{ "SAMSUNG MZ7TD256HAFV-000L9", NULL,       ATA_QUIRK_NOLPM },
> >  	{ "SAMSUNG MZ7TE512HMHP-000L1", "EXT06L0Q", ATA_QUIRK_NOLPM },
> >  
> > +	/* Hitachi-LG Data Storage models with LPM issues */
> > +	{ "HL-DT-ST BD-RE BU40N", NULL, ATA_QUIRK_NOLPM },
> > +
> >  	/* devices that don't properly handle queued TRIM commands */
> >  	{ "Micron_M500IT_*",		"MU01",	ATA_QUIRK_NO_NCQ_TRIM |
> >  						ATA_QUIRK_ZERO_AFTER_TRIM },
> > 
> > So if anyone has feedback on why the patch does not work or any
> > alternative ideas for a solution that would be highly appreciated!
> 
> It would be nice if you could share a dmesg.

See the attached dmesg, this is from the v6.13-rc6 kernel with the above
patch applied.

> If you have applied the quirk properly, I would expect to see something
> similar to:
> 
> [    2.989363] ata2.00: Model 'QEMU DVD-ROM', rev '2.5+', applying quirks: nolpm

Somehow the quirk does not apply to the model, i.e. the above line is
not to be found in the dmesg output. This is now the third time that a
kernel with this patch applied was built by two different people,
therefore I'd rule out build issues. Also I can find the following
output in my build log, which should give us a lot of confidence that
the patch was actually applied to the source:

    > Applying patch add-quirk-for-blueray.patch...
    > patching file drivers/ata/libata-core.c

Now the question is why the quirk does not work in the final result and
I don't know why that could be.

> Kind regards,
> Niklas

Thanks for all your inputs and quick responses!
Cheers,
Christian

View attachment "dmesg-6.13-rc6-mainline.log" of type "text/plain" (90412 bytes)

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)