linux-kernel - Re: [PATCH] arm64: dts: qcom: x1e80100: Mark usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z4FND-b-gEb6YJw6@hovoldconsulting.com>
Date: Fri, 10 Jan 2025 17:38:39 +0100
From: Johan Hovold <johan@...nel.org>
To: Mark Kettenis <kettenis@...nbsd.org>
Cc: Bjorn Andersson <andersson@...nel.org>,
	Konrad Dybcio <konradybcio@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Rajendra Nayak <quic_rjendra@...cinc.com>,
	Abel Vesa <abel.vesa@...aro.org>,
	Sibi Sankar <quic_sibis@...cinc.com>, johan+linaro@...nel.org,
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: x1e80100: Mark usb_2 as dma-coherent

On Thu, Jan 09, 2025 at 09:52:31PM +0100, Mark Kettenis wrote:
> Make this USB controller consistent with the others on this platform.
> 
> Fixes: 4af46b7bd66f ("arm64: dts: qcom: x1e80100: Add USB nodes")
> Signed-off-by: Mark Kettenis <kettenis@...nbsd.org>
> ---
>  arch/arm64/boot/dts/qcom/x1e80100.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> index 4936fa5b98ff..aad1153a443d 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> @@ -4814,6 +4814,8 @@ usb_2_dwc3: usb@...0000 {
>  				snps,dis-u1-entry-quirk;
>  				snps,dis-u2-entry-quirk;
>  
> +				dma-coherent;
> +

Can someone from Qualcomm please confirm that this is correct, and that
it's not the other way round and this property should be removed from
the other controllers (e.g. if this was just some copy-pasta from sm8550
which is the only other Qualcomm platform that claims to have
dma-coherent USB controllers).

Johan