linux-kernel - Re: [PATCH] treewide: const qualify ctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8534hqvbfv.wl-ashutosh.dixit@intel.com>
Date: Fri, 10 Jan 2025 09:13:56 -0800
From: "Dixit, Ashutosh" <ashutosh.dixit@...el.com>
To: Joel Granados <joel.granados@...nel.org>
Cc: Thomas Weißschuh <linux@...ssschuh.net>,	Kees Cook
 <kees@...nel.org>,	Luis Chamberlain <mcgrof@...nel.org>,
	linux-arm-kernel@...ts.infradead.org,	linux-kernel@...r.kernel.org,
	linuxppc-dev@...ts.ozlabs.org,	linux-riscv@...ts.infradead.org,
	linux-s390@...r.kernel.org,	linux-crypto@...r.kernel.org,
	openipmi-developer@...ts.sourceforge.net,	intel-gfx@...ts.freedesktop.org,
	dri-devel@...ts.freedesktop.org,	intel-xe@...ts.freedesktop.org,
	linux-hyperv@...r.kernel.org,	linux-rdma@...r.kernel.org,
	linux-raid@...r.kernel.org,	linux-scsi@...r.kernel.org,
	linux-serial@...r.kernel.org,	xen-devel@...ts.xenproject.org,
	linux-aio@...ck.org,	linux-fsdevel@...r.kernel.org,	netfs@...ts.linux.dev,
	codalist@...a.cs.cmu.edu,	linux-mm@...ck.org,	linux-nfs@...r.kernel.org,
	ocfs2-devel@...ts.linux.dev,	fsverity@...ts.linux.dev,
	linux-xfs@...r.kernel.org,	io-uring@...r.kernel.org,	bpf@...r.kernel.org,
	kexec@...ts.infradead.org,	linux-trace-kernel@...r.kernel.org,
	linux-hardening@...r.kernel.org,	apparmor@...ts.ubuntu.com,
	linux-security-module@...r.kernel.org,	keyrings@...r.kernel.org
Subject: Re: [PATCH] treewide: const qualify ctl_tables where applicable

On Thu, 09 Jan 2025 05:16:39 -0800, Joel Granados wrote:
>
> diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
> index 2406cda75b7b..5384d1bb4923 100644
> --- a/drivers/gpu/drm/i915/i915_perf.c
> +++ b/drivers/gpu/drm/i915/i915_perf.c
> @@ -4802,7 +4802,7 @@ int i915_perf_remove_config_ioctl(struct drm_device *dev, void *data,
>	return ret;
>  }
>
> -static struct ctl_table oa_table[] = {
> +static const struct ctl_table oa_table[] = {
>	{
>	 .procname = "perf_stream_paranoid",
>	 .data = &i915_perf_stream_paranoid,
> diff --git a/drivers/gpu/drm/xe/xe_observation.c b/drivers/gpu/drm/xe/xe_observation.c
> index 8ec1b84cbb9e..57cf01efc07f 100644
> --- a/drivers/gpu/drm/xe/xe_observation.c
> +++ b/drivers/gpu/drm/xe/xe_observation.c
> @@ -56,7 +56,7 @@ int xe_observation_ioctl(struct drm_device *dev, void *data, struct drm_file *fi
>	}
>  }
>
> -static struct ctl_table observation_ctl_table[] = {
> +static const struct ctl_table observation_ctl_table[] = {
>	{
>	 .procname = "observation_paranoid",
>	 .data = &xe_observation_paranoid,

For i915 and xe:

Acked-by: Ashutosh Dixit <ashutosh.dixit@...el.com>