linux-kernel - [PATCH 1/2] MIPS: Loongson64: remove ROM Size unit in boardinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250111-loongson64-boardinfo-no-size-v1-1-e9f26fcd069e@aosc.io>
Date: Sat, 11 Jan 2025 01:22:08 +0800
From: Kexy Biscuit <kexybiscuit@...c.io>
To: Huacai Chen <chenhuacai@...nel.org>, 
 Jiaxun Yang <jiaxun.yang@...goat.com>, 
 Thomas Bogendoerfer <tsbogend@...ha.franken.de>, 
 Tiezhu Yang <yangtiezhu@...ngson.cn>
Cc: linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org, 
 Kexy Biscuit <kexybiscuit@...c.io>, Mingcong Bai <jeffbai@...c.io>, 
 Icenowy Zheng <uwu@...nowy.me>, stable@...r.kernel.org
Subject: [PATCH 1/2] MIPS: Loongson64: remove ROM Size unit in boardinfo

Per Appendix A.7 in Q/LS 0013-2014 (龙芯CPU开发系统固件与内核接口规范 V2.2,
lit. Loongson DevSys Firmware Kernel Interface Specification V2.2),
interface_info.size is size of this interface, not size of the LEFI BIOS
ROM.

In any case, the BIOS ROM Size just cannot be several kilobytes (KB) on
Loongson64 LEFI platforms.

Reported-by: Mingcong Bai <jeffbai@...c.io>
Suggested-by: Icenowy Zheng <uwu@...nowy.me>
Fixes: 6c1bfbd9df8c ("MIPS: Loongson64: Add /sys/firmware/lefi/boardinfo")
Cc: stable@...r.kernel.org
Signed-off-by: Kexy Biscuit <kexybiscuit@...c.io>
---
 arch/mips/loongson64/boardinfo.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/mips/loongson64/boardinfo.c b/arch/mips/loongson64/boardinfo.c
index 280989c5a137b5f32708b21331b48bc581745130..8bb275c93ac0991c77827404d0c76cf97201a1a8 100644
--- a/arch/mips/loongson64/boardinfo.c
+++ b/arch/mips/loongson64/boardinfo.c
@@ -21,13 +21,11 @@ static ssize_t boardinfo_show(struct kobject *kobj,
 		       "BIOS Info\n"
 		       "Vendor\t\t\t: %s\n"
 		       "Version\t\t\t: %s\n"
-		       "ROM Size\t\t: %d KB\n"
 		       "Release Date\t\t: %s\n",
 		       strsep(&tmp_board_manufacturer, "-"),
 		       eboard->name,
 		       strsep(&tmp_bios_vendor, "-"),
 		       einter->description,
-		       einter->size,
 		       especial->special_name);
 }
 static struct kobj_attribute boardinfo_attr = __ATTR(boardinfo, 0444,

-- 
2.48.0.rc2