linux-kernel - Re: [PATCH] binder: log transaction code on failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z4FcTTuL0HAGKn74@google.com>
Date: Fri, 10 Jan 2025 17:43:41 +0000
From: Carlos Llamas <cmllamas@...gle.com>
To: Alice Ryhl <aliceryhl@...gle.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Arve Hjønnevåg <arve@...roid.com>,
	Todd Kjos <tkjos@...roid.com>, Martijn Coenen <maco@...roid.com>,
	Joel Fernandes <joel@...lfernandes.org>,
	Christian Brauner <brauner@...nel.org>,
	Suren Baghdasaryan <surenb@...gle.com>,
	linux-kernel@...r.kernel.org, kernel-team@...roid.com,
	Steven Moreland <smoreland@...gle.com>
Subject: Re: [PATCH] binder: log transaction code on failure

On Fri, Jan 10, 2025 at 01:11:32PM +0100, Alice Ryhl wrote:
> On Fri, Jan 10, 2025 at 1:05 AM Carlos Llamas <cmllamas@...gle.com> wrote:
> >
> > When a transaction fails, log the 'tr->code' to help indentify the
> > problematic userspace call path. This additional information will
> > simplify debugging efforts.
> >
> > Cc: Steven Moreland <smoreland@...gle.com>
> > Signed-off-by: Carlos Llamas <cmllamas@...gle.com>
> > ---
> >  drivers/android/binder.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> > index ef353ca13c35..cb4187a4e595 100644
> > --- a/drivers/android/binder.c
> > +++ b/drivers/android/binder.c
> > @@ -3801,13 +3801,13 @@ static void binder_transaction(struct binder_proc *proc,
> >         }
> >
> >         binder_debug(BINDER_DEBUG_FAILED_TRANSACTION,
> > -                    "%d:%d transaction %s to %d:%d failed %d/%d/%d, size %lld-%lld line %d\n",
> > +                    "%d:%d transaction %s to %d:%d failed %d/%d/%d, code %d size %lld-%lld line %d\n",
> 
> Shouldn't this by %u instead?

Yes, with tr->code being u32 it technically should use %u. I'll send a
new version. Thanks!